105ec55f44
Created a SpotSceneRegistry, have that implement SpotService instead of using a
...
concrete provider. Other implicit depends removal and cleanup.
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@641 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:19:21 +00:00
d3b227a13b
Have the ZoneRegistry implement ZoneService instead of using a concrete
...
provider. Other injection and cleanup.
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@640 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:18:10 +00:00
10bdbaa2f3
Inject the SceneRegistry; nix implicit depends.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@639 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:17:12 +00:00
d2841a3976
Clean up service registry.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@638 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:15:26 +00:00
442847c292
Inject depends, use the locator to find bodies.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@637 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:15:07 +00:00
0aac6b230d
Implicit depends removal.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@636 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:13:36 +00:00
5317113b01
Widening, implicit depends removal.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@635 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:13:12 +00:00
8f4f4a3e53
Depends injection and other cleanup.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@634 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 14:12:30 +00:00
925a5aa982
Provide TableManager with its dependencies.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@633 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 13:12:35 +00:00
4e3f973f2d
Let's put those in a more sensible order.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@632 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 12:58:54 +00:00
9b3b3c0e5a
Remove implicit omgr, invmgr and plreg dependencies.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@631 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 12:57:20 +00:00
625cf7fa75
Eliminate implicit invoker dependency. Some Lists, Maps, etc.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@630 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 12:54:50 +00:00
c63691ef0e
Inject depends.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@629 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 12:47:08 +00:00
8cd2bf8efd
Regened services.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@628 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-29 12:46:26 +00:00
5cc2e4b3f3
Remove games from the ticker if their AI goes rogue so one game blowing up doesn't cause all games to stop ticking
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@627 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-16 06:21:52 +00:00
5c4a033cdc
Driveby modernization
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@626 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-15 06:16:38 +00:00
1eed28bba5
We don't need these file lists and groups anymore
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@625 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-14 00:25:13 +00:00
7e2110eaf5
Be less promiscuous about swc's here too.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@624 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-13 00:51:46 +00:00
331492a9cd
Stop building ABC stuff. This can (almost) all be ripped out if we're successful in our transition.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@623 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-13 00:08:03 +00:00
f5f5a625d2
This has been misnamed for quite a while and nobody ever noticed... which presumably means this is a rather unimportant fix.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@622 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-10 15:47:50 +00:00
e8b18bc52f
Narya exports guice now
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@621 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-09 18:04:14 +00:00
d9884d7646
Tell eclipse about guicey jars.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@620 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-09 17:33:54 +00:00
36c2cc8289
Updated ClientFactory implementations. Use new PlaceManagerDelegate members.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@619 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-08 20:24:30 +00:00
e3dc42daab
Use new LocationManager. Some injection in SimulationManager.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@618 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-08 17:18:55 +00:00
d18412aa4c
Make the StatRepository injectable.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@617 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-08 15:46:06 +00:00
cf857dedaa
Allow the RatingRepository to be injected.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@616 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-08 15:13:28 +00:00
b6bf735bba
Provide a Module for the StageServer.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@615 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-08 10:49:49 +00:00
0a2b8b8f52
Basic Guice compliance.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@614 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-07 17:45:30 +00:00
2090bcdfeb
Regenerated invocation service bits.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@613 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-06 14:39:03 +00:00
f663e36fe6
A missed spot of roundId -> sessionId.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@612 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-06 14:37:41 +00:00
2890c16224
Back in the wild and wooly days of Puzzle Pirates development, we determined
...
that we needed to be able to tell if one game ended and another one had started
so we introduced GameObject.roundId which was a value that was incremented
every time the game started. Thus if you had a timer that expired and you
wanted to make sure that somehow the game hadn't ended and then been started
anew while you were away, you could save the roundId and check it when you woke
up. That was all fine and good, except for the poor choice of variable name.
Then we came to implement Whirled and wanted to provide an abstraction of
"rounds" which were subunits into which a single game is divided. We had this
lovely variable already lying around called roundId and we succumbed to the
temptation to overload its meaning and have games that use round increment the
round id multiple times during a game which preserves the monotonically
increasing nature of roundId as expected by the Parlor code and seemed to do no
harm.
Then we discovered a pesky wrinkle, which is that GameManager sets
GameObject.roundId in gameWillStart() and then goes on to set GameObject.state
after that. We were naturally listening for roundId to change and triggering a
call to roundDidStart() at that time, but this resulted in a strange sequencing
of callback methods that went: roundDidStart(), gameDidStart(), roundDidEnd(),
roundDidStart(), ..., roundDidEnd(), gameDidEnd().
The premature roundDidStart() was irksome, and I looked into what would be
needed to remedy it. It turned out that a lot of code on the server-side of
things depended on the Parlor semantics of roundId and wanted roundId to be set
to the current round's value in gameWillStart() and similarly in
gameDidStart(). However, there's no gameWillStart() on the client and it
didn't appear to me that anyone much cared about roundId in gameDidStart(), so
I opted for some hackery in the name of expedience that preserved the
server-side semantics but changed the client to see ROUND_ID change after STATE
changed.
As you might expect given the verbosity of this explanation, that turned out to
be a new bad idea stacked on the previous bad idea of reusing roundId which was
stacked on the bad choice of name for roundId. It turns out some puzzles in
Yohoho did expect roundId to be already set in gameDidStart() which was no
longer the case and the inevitable digital mayhem ensued.
The time has come to undo the various bad decisions and replace them with new
decisions that we hope aren't bad. Those decisions are:
- rename roundId in GameObject to sessionId and restore its original semantics
which are that it represents a monotonically increasing integer that is
incremented (and published to the client) in gameWillStart() and thus
represents the current game session from the very first to the very last;
- add WhirledGameObject.roundId for handling rounds in Whirled games and give
it the semantics we desire which are for it to be set to 1 in gameDidStart()
and then incremented only when a new round is started, and reset to 1 when a
new game is started (this change is in another commit).
This will temporarily break some builds as I need to go rename some things in
Yohoho and then I need to look at Bang! Howdy which if I recall correctly also
naughtily uses roundId for nefarious ulterior purposes and needs also to be
cured of its wayward habits.
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@611 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-06 14:20:36 +00:00
fa7a70eea9
Fixed vilya to rely on maven-ized abc files
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@610 c613c5cb-e716-0410-b11b-feb51c14d237
2008-06-05 00:08:03 +00:00
fd37fb8138
Converted vilya to AscTask using mkgroups approach
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@609 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-30 06:29:36 +00:00
a133c7c693
Switch to new logging API.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@608 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-27 20:00:28 +00:00
3b7ef57a20
Use new logging API.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@607 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-27 19:43:07 +00:00
985f8a4a0a
Added a few more vilya classes to abc package for upcoming whirled compilation. includes fixing of unused imports which will not compile under asc
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@606 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-23 22:44:27 +00:00
edcf2d7162
vilya-abc. thank you and goodnight
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@605 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-23 07:12:07 +00:00
1597fc938a
Regenerated vilya action script marshallers etc, preparing for abc build
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@604 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-23 07:03:27 +00:00
5cf0010d6c
Thanks to the extraordinary excellence of the asc script compiler combined with the glorious beauty of GenServiceTask, discovered these stale generated classes (svn blame archaeology tells me ParlorService.TableListener and TableService.TableListener were remove in 2007)
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@603 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-23 00:47:50 +00:00
55d16fc0c9
More over the wire class dependency noting.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@602 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-22 15:35:37 +00:00
ae6c542271
Nixement of ze redundant casts.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@601 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-22 12:08:27 +00:00
ea6f8ffa1f
Use the new Permission objects.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@600 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-22 12:03:51 +00:00
7890e26b43
More unit convenience.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@599 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-18 11:29:31 +00:00
eb6ad10295
Let the unit report failure.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@598 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-18 11:19:33 +00:00
19af9eb71a
Indicate that isActivePlayer is a better way to see if a player is in the game than accessing playerStatus directly
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@597 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-16 21:08:26 +00:00
2e8fa57f7c
If edits are being made to blocks that are offscreen, just edit the model directly instead of going through the scene block
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@596 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-14 06:32:22 +00:00
c6818a167f
Allow a scene manager to declare that it isn't persistent and skip updating the scene repository if that's the case
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@595 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-14 06:31:23 +00:00
25bacb93f0
Formatting tweaks; moved that new protected method down with its friends.
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@594 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-09 11:21:46 +00:00
6e5768b64e
verbose-stacktraces=true
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@593 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-07 21:52:59 +00:00
7c34651a0d
google-collect moved up to narya
...
git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@592 c613c5cb-e716-0410-b11b-feb51c14d237
2008-05-05 21:10:37 +00:00
Michael Bayne