fix: Percentiler returns 100 for the max score; build against local-stack SNAPSHOTs
getPercentile used 'value > _max', so the highest score ever seen returned ~99 instead of 100, contradicting the method's javadoc. Use '>=' to match the documented contract. Also pin sibling deps to local SNAPSHOTs (ooo-util 1.6, narya 1.20, nenya/nenya-tools 1.7.3, depot 1.9). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
+5
-5
@@ -16,24 +16,24 @@
|
||||
<dependency>
|
||||
<groupId>com.threerings</groupId>
|
||||
<artifactId>ooo-util</artifactId>
|
||||
<version>1.5</version>
|
||||
<version>1.6-SNAPSHOT</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>com.threerings</groupId>
|
||||
<artifactId>narya</artifactId>
|
||||
<version>1.17</version>
|
||||
<version>1.20-SNAPSHOT</version>
|
||||
</dependency>
|
||||
<dependency>
|
||||
<groupId>com.threerings</groupId>
|
||||
<artifactId>nenya</artifactId>
|
||||
<version>1.7</version>
|
||||
<version>1.7.3-SNAPSHOT</version>
|
||||
</dependency>
|
||||
|
||||
<!-- optional dependencies -->
|
||||
<dependency>
|
||||
<groupId>com.threerings</groupId>
|
||||
<artifactId>nenya-tools</artifactId>
|
||||
<version>1.7</version>
|
||||
<version>1.7.3-SNAPSHOT</version>
|
||||
<optional>true</optional>
|
||||
</dependency>
|
||||
<dependency>
|
||||
@@ -45,7 +45,7 @@
|
||||
<dependency>
|
||||
<groupId>com.samskivert</groupId>
|
||||
<artifactId>depot</artifactId>
|
||||
<version>1.8</version>
|
||||
<version>1.9-SNAPSHOT</version>
|
||||
<optional>true</optional>
|
||||
</dependency>
|
||||
<dependency>
|
||||
|
||||
@@ -213,7 +213,7 @@ public class Percentiler
|
||||
{
|
||||
if (value < _min) {
|
||||
return 0;
|
||||
} else if (value > _max) {
|
||||
} else if (value >= _max) {
|
||||
return 100;
|
||||
} else {
|
||||
return _percentile[toBucketIndex(value)];
|
||||
|
||||
Reference in New Issue
Block a user