Falling through is a dangerous pattern, let's not do it.

git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@116 c613c5cb-e716-0410-b11b-feb51c14d237
2006-10-26 23:11:56 +00:00
parent e9fe2aab01
commit 16f070f69c
2 changed files with 5 additions and 2 deletions
@@ -169,7 +169,9 @@
      <exclude name="**/ModPlayer.java"/>
      <exclude name="**/MidiPlayer.java"/>
      <exclude name="**/Mp3Player.java"/>
-      <!--<compilerarg value="-Xlint:unchecked"/>-->
+      <compilerarg value="-Xlint"/>
+      <compilerarg value="-Xlint:-serial"/>
+      <compilerarg value="-Xlint:-unchecked"/> <!-- TODO: fix -->
    </javac>
  </target>

@@ -68,9 +68,10 @@ public class PortalTool extends MouseInputAdapter
        switch (event.getButton()) {
        case MouseEvent.BUTTON1:
            savePortal();
-            // fall through to BUTTON3
+            break;

        case MouseEvent.BUTTON3:
+            savePortal();
            dispose();
            break;
        }