Commit Graph

2723 Commits

Author SHA1 Message Date
ray.j.greenwell 634bacae14 Jamie Doornbos points out that I made a booboo here.
Our getOr() will skip the first argument if it is "blank"
(null, empty, or all whitespace), not just null.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2783 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-20 14:28:19 +00:00
ray.j.greenwell 668ad3ec55 - Fixed parsing of byte[]s to not parse them as strings and then
lose precision during the cast. Now it will freak out if the
  "byte" is out of range.
- A bit less hashing in our static initializer.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2782 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-20 01:50:37 +00:00
ray.j.greenwell edf86bdfec I won't deprecate replace() outright, but it's in String now.
(Although, the implementation builds a Pattern object, which
seems rather wasteful if the match sequence isn't found..)


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2781 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-20 01:43:56 +00:00
ray.j.greenwell ab062e7e95 Let's go ahead and unmarshall to all the wrapper types, not just Integer.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2780 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-17 00:06:43 +00:00
ray.j.greenwell 835f1268d0 This class can now accurately store null.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2779 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 01:13:36 +00:00
ray.j.greenwell 181eb3faf0 Gah! Gringos falling from the sky?
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2778 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 01:12:27 +00:00
ray.j.greenwell 40e36046d0 Whitespace patrol.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2777 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 00:57:08 +00:00
ray.j.greenwell 5fa1380c5c @ReplacedBy something in guava.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2776 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 00:56:39 +00:00
ray.j.greenwell 12c107bd29 Why is this <T extends Object>?
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2775 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 00:56:06 +00:00
ray.j.greenwell 3ad9520cb0 Everything here can be @ReplacedBy something else.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2774 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 00:55:42 +00:00
ray.j.greenwell 0454f1cf84 After some discussion, two changes:
- If there is only one element in the Iterable, compare it to itself to
  make sure it's not "bogus", like null in the Comparable version.
- Use our own natural ordering Comparator, as the one in Comparators is null-safe. Gah!


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2773 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-16 00:55:13 +00:00
ray.j.greenwell ae67d873e8 Added maxList() and minList().
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2772 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-15 23:57:05 +00:00
samskivert 25f93f6bed Switch to JUnit4 style.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2771 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-15 23:33:20 +00:00
ray.j.greenwell a072d4f1a4 Replace both of these by HashMultiset.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2770 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-05 18:34:32 +00:00
ray.j.greenwell 5b1a640433 I thought since @ReplacedBy was both @Documented and @Inherited, that it would
show up on HashIntMap when I added it to IntMap. Not so. Apparently it only works
for superclasses, no implemented interfaces, and it may also not apply to
non-runtime annotations.

So: add @ReplacedBy to these IntMap-related classes.
I've not yet used @ReplacedBy on IntSet, and I guess some people still
really like their ArrayIntSet, but the memory gain is minimal and it's actually
usually a loss in terms of performance.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2769 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-04-05 18:31:29 +00:00
andrzej@threerings.net b7273518b8 getRange -> getInRange.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2768 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-31 22:35:04 +00:00
ray.j.greenwell e42c8e8b60 getRange() -> getInRange().
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2767 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-31 22:09:00 +00:00
ray.j.greenwell dc4bbffb48 - Change ReplacedBy values...
- CollectionUtil.limit doesn't need to know the Collection type.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2766 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-31 21:11:08 +00:00
ray.j.greenwell a4d53dcbb8 Added getRange(), in int and float versions, and deprecated getInt(high, low),
because the parameter ordering and exclusive-of-low makes everybody cry.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2765 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-31 21:06:04 +00:00
ray.j.greenwell d68ba4d9a1 Allow a reason to be specified on ReplacedBy. Annotate IntMap.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2764 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-31 17:41:41 +00:00
ray.j.greenwell ac30065aab Some more @ReplacedBy annotating.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2763 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-29 21:49:25 +00:00
samskivert ed9f8502e0 No need for this kooky inner assignment.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2762 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-29 16:57:24 +00:00
ray.j.greenwell aab57210e5 Use @ReplacedBy a few more places.
I'm going to start adding this more aggressively as I come across "old things".


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2761 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-26 17:57:47 +00:00
ray.j.greenwell b168db60f4 Let's have this annotation be inherited.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2760 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-26 17:57:06 +00:00
samskivert bfc97858b6 Patch from Dave to excise all remaining tabs.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2759 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-24 21:37:44 +00:00
charlie.groves 1eec46f02a 1.5 compatibility for yohoho
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2758 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-08 09:33:55 +00:00
samskivert 8d3dbe9346 If PERF_TRACK was set to false, start was never initialized, so compilation
would fail.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2757 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-07 19:19:19 +00:00
samskivert 6facd3d12f 1.7 javac is apparently more perceptive than ejc when it comes to warning about
raw type usage. I'm surprised that the Eclipse code hygienist failed to catch
these. Also had to be slightly more blatant in a few places where we're
subverting the generics type system because the 1.7 javac is less tolerant of
the fast and loose.

For future reference, that usually means first assigning a reference to a
wildcard and then casting that to what you want:

Foo<?> fc = someFooWithCrazyAssParameters;
@SuppressWarnings("unchecked") Foo<Object> fo = (Foo<Object>)fc;

instead of just:

@SuppressWarnings("unchecked") Foo<Object> fo =
    (Foo<Object>)someFooWithCrazyAssParameters;

because javac won't let you do casts that are inconvertible and it's smarter
about what sort of generic types are convertible to one another.

Hopefully this future reference won't be needed because we won't be needing to
subvert the type system. But when reflection is involved, it's hard not to end
up doing a bit of the old Father Knows Best.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2756 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-07 18:10:10 +00:00
ray.j.greenwell 82083248a6 Typo. Caught by Charlie Groves. I shoulda just used his diff directly
but I omitted one thing and... well, look where it got me.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2755 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-05 01:02:27 +00:00
ray.j.greenwell c5203171f4 Also via Charlie, noticed by Eclipse: naming consistency with other methods.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2754 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-04 21:39:06 +00:00
ray.j.greenwell 51c6b89c8e Via Charlie Groves, some changes flagged by Eclipse.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2753 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-04 21:38:15 +00:00
ray.j.greenwell 8a371eebf9 Since I ended up naming the little protected helper method "toIntFlag",
let's have it go ahead and return a flag rather than the bit position.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2752 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-02 05:38:35 +00:00
ray.j.greenwell b4c8b3fda8 Added setToInt() and intToSet(), for turning a Set<ByteEnum> into an
encoded form for storing in a database or otherwise persisting into an
int.

It would be snazzy if Depot could do this automatically if a PersistentRecord
contained a Set<E extends Enum<E> & ByteEnum>.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2751 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-03-01 20:17:26 +00:00
samskivert 1a4091b49a Added a TerseLogFormatter for those times when you don't want to spend 80% of
your terminal width on incidentals. Factored some shared bits into
FormatterUtil.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2750 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-19 18:56:42 +00:00
ray.j.greenwell 383aaa58f8 From Michael Thomas: reinstate blocking of super.finalize().
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2749 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-17 21:22:24 +00:00
ray.j.greenwell a6beaab29a Via Nathan Curtis: allow the time to be set directly on a builder that
was constructed with a specific zone and locale.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2748 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-12 01:32:22 +00:00
ray.j.greenwell e6970e1c91 Via Nathan Curtis: A method on Builder to set the TimeZone.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2747 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-11 22:03:26 +00:00
samskivert acb2fffb0a Beans frank.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2746 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 16:26:11 +00:00
samskivert 0468902779 Widened, untabified, added equals() and hashCode() implementation to
SynchronizedIntSet.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2745 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 01:17:23 +00:00
samskivert d4678372be This must be some leftover C-ism because (x & 0xffffffff) == x for int
variables.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2744 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 01:09:39 +00:00
samskivert 82a664c879 Use unsigned shift to avoid breakage on overflow.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2743 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 01:03:32 +00:00
samskivert fc638663eb Untabify.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2742 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 01:01:47 +00:00
samskivert ad3736e055 Be more specific about what we catch.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2741 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 01:01:11 +00:00
samskivert b4c32aeb84 Simplify, cope with nulls.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2740 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:59:54 +00:00
samskivert 420df91056 More FindBugs inspired hygeine.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2739 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:53:15 +00:00
samskivert 9d9b5a5649 We don't actually want an inner class here with its outer this pointer and
ability to implicitly call methods on its outer class. We just need a static
wrapper.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2738 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:48:14 +00:00
samskivert 726aec37ed We don't use or need the integer codes in our policy and justification constant
objects.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2737 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:42:22 +00:00
samskivert 4da25bc39b Use a string builder.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2736 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:40:16 +00:00
samskivert fa938b847f Small rearrangement.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2735 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:40:07 +00:00
samskivert 0aeab762aa Untabified. Made some string building use StringBuilder.
git-svn-id: https://samskivert.googlecode.com/svn/trunk@2734 6335cc39-0255-0410-8fd6-9bcaacd3b74c
2010-02-10 00:39:37 +00:00