AfflictionNetworks/samskivert
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added code to cache resolved resource bundles in the request object so

Browse Source 
that we don't have to re-resolve the bundle for every single message
lookup.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@431 6335cc39-0255-0410-8fd6-9bcaacd3b74c
This commit is contained in:
mdb
2001-11-06 05:35:54 +00:00
parent 864d282c3d
commit 8d4c490c0d
1 changed files with 39 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/samskivert/src/java/com/samskivert/servlet/MessageManager.java
+39 -16
View File
@@ -1,5 +1,5 @@
// //
// $Id: MessageManager.java,v 1.2 2001/08/11 22:43:28 mdb Exp $ // $Id: MessageManager.java,v 1.3 2001/11/06 05:35:54 mdb Exp $
// //
// samskivert library - useful routines for java programs // samskivert library - useful routines for java programs
// Copyright (C) 2001 Michael Bayne // Copyright (C) 2001 Michael Bayne
@@ -114,6 +114,15 @@ public class MessageManager
protected ResourceBundle resolveBundle (HttpServletRequest req) protected ResourceBundle resolveBundle (HttpServletRequest req)
throws MissingResourceException throws MissingResourceException
{ {
// first look to see if we've cached the bundle for this request
// in the request object
ResourceBundle bundle = (ResourceBundle)
req.getAttribute(BUNDLE_CACHE_NAME);
if (bundle != null) {
return bundle;
}
// otherwise try looking up the appropriate bundle
Enumeration locales = req.getLocales(); Enumeration locales = req.getLocales();
while (locales.hasMoreElements()) { while (locales.hasMoreElements()) {
@@ -128,12 +137,11 @@ public class MessageManager
// matches on any of the preferred locales specified by // matches on any of the preferred locales specified by
// the client. if we don't, then we can rely on java's // the client. if we don't, then we can rely on java's
// fallback mechanisms // fallback mechanisms
ResourceBundle bundle = bundle = ResourceBundle.getBundle(_bundlePath, locale);
ResourceBundle.getBundle(_bundlePath, locale);
// if it's an exact match, off we go // if it's an exact match, off we go
if (bundle.getLocale().equals(locale)) { if (bundle.getLocale().equals(locale)) {
return bundle; break;
} }
} catch (MissingResourceException mre) { } catch (MissingResourceException mre) {
@@ -142,21 +150,36 @@ public class MessageManager
} }
} }
try { // if we were unable to find an exact match for any of the user's
// if we were unable to find an exact match for any of the // preferred locales, take their most preferred and let java
// user's preferred locales, take their most preferred and let // perform it's fallback logic on that one
// java perform it's fallback logic on that one if (bundle == null) {
return ResourceBundle.getBundle(_bundlePath, req.getLocale()); try {
bundle = ResourceBundle.getBundle(
_bundlePath, req.getLocale());
} catch (MissingResourceException mre) { } catch (MissingResourceException mre) {
// if we were unable even to find a default bundle, we've got // if we were unable even to find a default bundle, we've
// real problems. time to freak out // got real problems. time to freak out
Log.warning("Unable to resolve any message bundle " + Log.warning("Unable to resolve any message bundle " +
"[bundlePath=" + _bundlePath + "[bundlePath=" + _bundlePath +
", locale=" + req.getLocale() + "]."); ", locale=" + req.getLocale() + "].");
return null; }
} }
// if we found a bundle, cache it
if (bundle != null) {
req.setAttribute(BUNDLE_CACHE_NAME, bundle);
}
return bundle;
} }
/** The path, relative to the classpath, to our resource bundles. */
protected String _bundlePath; protected String _bundlePath;
/** The attribute name that we use for caching resource bundles in
* request objects. */
protected static final String BUNDLE_CACHE_NAME =
"com.samskivert.servlet.MessageManager:CachedResourceBundle";
} }