d3d3528d83
Fix another issue with the log message in here. That would have looked strange indeed, in the logs.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5290 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 18:49:42 +00:00
e14bbe5a02
the varargs logger is so fancy that it supplies "=" for us.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5289 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 18:16:08 +00:00
9ae87e7c2b
Let's make that an else as well.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5288 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 18:12:28 +00:00
aba13e5718
Oops, that's tests not test.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5287 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 18:11:01 +00:00
93cffda93f
Actually Eclipse was telling us something useful. The point of that code was to
...
issue a warning if someone created a reader method or a writer method but not
both. Eclipse's static analysis helpfully pointed out that we'll never know if
someone fails to declare a reader but does declare a writer because of the way
method lookup fails. Since we want to actually detect that situation and
generate a helpful warnings, we restructure the code so that the static
analyzer is happy and developers asses are covered.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5286 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 18:09:55 +00:00
1fafa17293
Dave added the @SuppressWarnings("unchecked") because his stricker warning system in Eclipse told
...
him (correctly) that some of the null checking there was not needed. If you have that setting
off, however, Eclipse warns that the @SuppressWarnings itself is unneeded. So, instead of freaking
out Eclipses of one persuasion or the other, lets just clean up the code and add an explanatory
comment.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5285 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 17:58:45 +00:00
024e112796
More output fixes.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5284 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-04 17:47:36 +00:00
c24d78a0ea
Super pedantic warning mode freaks out about the check in there since it really
...
knows some of those states of nullness can't exist, but the conditional
really reads nicely and conveys what's going on, so let's just suppress the warning.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5283 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-01 18:53:52 +00:00
29ada80ce5
Let's call a PlaceConfig a PlaceConfig.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5282 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-01 14:38:01 +00:00
0b6d823e8a
Fixed ChainedResultListener declaration.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5281 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-08-01 13:19:24 +00:00
3b032cacac
Move PlayManager*.java from crowd.server to parlor.server.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5280 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-31 17:28:09 +00:00
b6b9786e17
We want to share delegates between GameManager games and AVRGameManager games, but AVRGameManager extends PlaceManager directly. This is the proposed solution: a PlayManager interface, and an associated PlaceManagerDelegate. I'm open for suggestions for better names.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5279 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-31 05:32:07 +00:00
2cdac9dfcb
Need to include the service class when linking to a listener defined in it. This makes Eclipse happy. Javadoc emits warnings in the current form without the service class, in the new form with <service>.<listener> and also with <service>#<listener>. I just want to please javadoc, but I don't know how.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5278 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 18:16:12 +00:00
f0c529bb19
generate a little less needless whitespace
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5277 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 17:21:25 +00:00
efaea0660c
Mark an override
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5276 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 17:19:58 +00:00
bda7d04f4c
Peskily, Eclipse and javac disagreed about whether this unchecked suppression
...
was necessary (javac claimed it was, Eclipse claimed it wasnt'). Fortunately,
we can do everything with Class<FooClient> methods that avoid the need for
supression entirely.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5275 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 13:05:16 +00:00
725f656197
Fixed a bunch of type safety bits pointed out by the latest version of Eclipse.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5274 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 12:58:51 +00:00
ca4c5897fb
Tidied up.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5273 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 09:32:48 +00:00
81dc030710
don't lazily create _isStreamableFieldPred
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5272 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 01:05:23 +00:00
c17634f7a8
Removed illegal @link asdoc directive from service generation templates
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5271 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 00:20:13 +00:00
7a1ede64af
Added a NotStreamable annotation. Streamable objects that have fields annotated with NotStreamable will not have those fields sent over the wire, at least by the default readObject()/writeObject() Streamer methods.
...
Currently, Streamer will skip fields marked transient for the purposes of the default streaming implementation, but 'transient' is also used by the Java serialization mechanism, and there are instances where a field in a Serializable, Streamable object can't be streamed but should be serialized.
I have a bunch of code to check in related to the game server sending stat updates to the world server, but I'm going to hold off on those changes until I get the go-ahead from the powers that be that this is an acceptable solution to the problem.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5270 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-30 00:04:06 +00:00
97e91dbb84
Restored the old setCommandGenerator function for the test client, it was accidentally blown away when timeouts got added
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5269 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-28 17:28:44 +00:00
8a8b615f9d
Clean up some warnings I'm getting in super-pedantic mode.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5268 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-28 17:23:07 +00:00
93fb7b01f7
Fixed some unused variables, unused imports, type variable hiding, tricky
...
generic array type handling and other niggling bits.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5267 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-26 20:40:20 +00:00
4fab6bb71a
Reset a bureau if its launcher does not connect back in a timely fashion
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5266 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-25 22:58:03 +00:00
4a5f474183
Tidied up registry log message, line lengths and use of static final int instead of an enum
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5265 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-25 22:15:56 +00:00
79d7d60770
MDB would prefer that we ignore these via .subversion/config, rather than svn:ignore.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5264 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-25 17:28:20 +00:00
df449d6954
Lets go ahead and svn:ignore the Flex Builder property files
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5263 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-24 21:55:42 +00:00
551326910c
Bureau registry doesn't need to listen for client object death now that it listens for the end of a session. This was causing a warning in the log when the bureau was not found on the second call to clientDestroyed
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5262 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-24 21:01:00 +00:00
0a46e0b742
Well, shit. MDB points out something I completely missed: these Flex Library Project files contain
...
an enumerated list of every class in the library. Since there are (as far as I know) only two
people currently using Flex Builder, and since these project files are easy to create and maintain
locally, lets not deal with keeping a versioned copy up to date every time a file is created,
removed or renamed.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5261 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-24 16:25:35 +00:00
2b3b5411cc
Removed deprecated way of initializing the bureau registry client factory
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5260 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-24 04:55:10 +00:00
5567d7e22f
Flex Builder project files for narya as a Flex Library project
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5259 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-23 20:42:14 +00:00
4a9265410a
Inject dependencies into delegates supplied to PlaceRegistry.createPlace().
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5258 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-23 12:15:52 +00:00
f2eeab0581
Truth in commenting.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5257 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 23:12:55 +00:00
1b29e41129
BootstrapData.services is now a plain old array.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5256 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 18:29:06 +00:00
9674176268
More debugging when debug is activated.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5255 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 18:28:36 +00:00
dde4e4bfdf
Presents supports streaming lists natively now, so just use an array list.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5254 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 15:06:36 +00:00
0a893e1de1
ZOMG, Narya now perfectly passes our coding standards as enforced by
...
CheckStyle. The checks are slightly looser than I'd like but way better than
nothing and we get a bunch of other useful warnings like shadowed names and
other handy bits.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5253 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 14:36:54 +00:00
5c4ab96880
Styley stylopolis.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5252 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 14:01:51 +00:00
706b85a0e4
Regenerated with new code that properly simplifies generic type arguments.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5251 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 13:48:37 +00:00
e1ca08dde8
Simplified (and improved) name simplification.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5250 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 13:48:10 +00:00
67ce73b61d
More style cleanup.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5249 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 13:39:42 +00:00
c743432676
More style changes.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5248 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 13:02:13 +00:00
09f8a25876
More style-related cleanup.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5247 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 12:51:17 +00:00
0aa0e48c28
The provider needs to import the service for all of our javadoc to work. If
...
Eclipse doesn't know about javadoc, we should file a bug.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5246 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 12:50:15 +00:00
85b26867e3
Put this all on one line to avoid weird whitespace.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5245 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 12:48:57 +00:00
219ab38b77
Widening; nixed import of receiver as it's not needed.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5244 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-22 12:33:37 +00:00
bd285bafc7
Teach that switch statement about all values for that enum.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5243 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-21 18:24:04 +00:00
d01715a369
More style fixes.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5242 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-19 09:50:20 +00:00
6b1d65553f
And finally, narya gets the imports/overrides/regen love.
...
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5241 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-07-18 23:20:17 +00:00
Nathan Curtis