Commit Graph

5524 Commits

Author SHA1 Message Date
Michael Bayne 49f2bdb493 Extract occupant info adding into an overridable method so that derived classes
can both participate in the combined event that adds an occupant's info and can
coordinate whether their info is added before or after.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5586 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 01:04:05 +00:00
Ray Greenwell a3e1c6e09e Fixup.
If there's an error when calling the callback function,
we were assuming it was an argument-related error and trying again.
However, this is sorta bad behavior as we don't want to call
twice into a callback. In the case I was seeing, the first time
in caused an NPE, but popped up a panel, and the second try
was no-opping because the panel was already up (but misconfigured).

So: don't even try a second call, because it looks like
flash will accept args to an argless function.
We'll have to try this out for a while and see if it works.
If so, I can neaten this code. If not, I'll uncomment
some of this and try a more surgical approach (only catch
ArgumentError, only retry if we had 1 boolean arg.)


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5585 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-09 23:23:15 +00:00
Par Winzell dc2c4e7793 Don't hardcode the TEXT data type; it'll still be chosen for use by MySQL and PostgreSQL because of the length of the field. Is 64k enough?
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5584 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-09 22:50:52 +00:00
Ray Greenwell 5f69af762d Reorder the args to these adapters: success is first now, followed by failure.
This has been wacked-out like this ever since I first wacked it out.
Since the base class is ResultAdapter and it only takes failure, and the
'processed' function for ConfirmAdapter is optional, it seemed to make
sense this way.
But, we have another ResultAdapter (for non-invocation ResultListener)
and it expects success first.
So Mike noticed this today (I swear there was a big brouhaha about this
over the summer) and beat me with my own rubber chicken.
I'm not sure why I had a mental block about reordering, but let's do it!


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5583 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-09 02:20:48 +00:00
Michael Bayne 343a2a7026 Nix unread variable.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5582 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-08 19:01:17 +00:00
Nathan Curtis 34d2833580 Enums can safely be used as Dictionary keys, and should therefore pass the isSimple() test.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5581 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-06 00:39:05 +00:00
Michael Bayne 92713ee4b8 Let's do our adding in a single event.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5580 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 22:03:04 +00:00
Michael Bayne 74bccd4223 Clean up occupant info creation and whatnot. Now we have a nice calldown method
bodyWillEnter() where the PlaceManager can do whatever they want when the body
enters, before or after the occupant info creation process.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5579 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 22:01:25 +00:00
Michael Bayne c793aff440 Unused import nixage.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5578 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 03:08:57 +00:00
Michael Bayne 12da80af98 Fix NameUpdater name.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5577 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 01:39:12 +00:00
Michael Bayne 6ece773295 NameUpdater not NameUpdate.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5576 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 01:38:40 +00:00
Michael Bayne 0942566fc3 Added a handy update for changing an occupant's name.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5575 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 01:31:30 +00:00
Michael Bayne c116f93a7b Fiddlesticks. Let's unify these update methods and do away entirely with the
old dangerous way of updating. We will now use only the timeless way.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5574 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 00:51:37 +00:00
Michael Bayne 62f393db95 Hold the phone. I already wrote this code. Sheesh.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5573 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-04 23:29:42 +00:00
Michael Bayne 420333df51 Made it easier to update occupant info the correct way in hopes of discouraging
people from updating it the wrong way.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5572 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-04 23:28:50 +00:00
Michael Bayne 46a5bbd0cc Don't cache our nodes query. We always want the latest and the freshest.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5571 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-02 21:58:50 +00:00
Dave Hoover 34ae8910d7 Widen & break one thing out so I can avoid copy & paste when I format
a very similar message in the yohoho reboot manager.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5570 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-27 00:30:48 +00:00
Michael Bayne 14307d7292 Break out communicator creation into an overridable method temporarily.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5569 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-26 23:57:17 +00:00
Jamie Doornbos adf11c5381 Fixed index out of bounds exception. This was causing msoy aux reporters to never complete if the report type was not registered on the game server (e.g. servlet ony)
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5568 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-24 23:01:16 +00:00
Mike Thomas a5b8aad082 Prevent a divide by zero that we're seeing occasionally on startup.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5567 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-21 00:22:51 +00:00
Ray Greenwell e649880f90 Allow a message to be passed to happy testing dumpStack()
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5566 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-20 19:48:47 +00:00
Ray Greenwell 7b9c0501a6 Added no-args generateReport() to generate default report.
There is a registerReporter() that doesn't take a type, so this
seemed like the way to go, rather than changing msoy to
pass in DEFAULT_TYPE.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5565 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 21:15:39 +00:00
Michael Bayne 457c8a59d6 Allow reporters to be registered for different report types and the type to be
specified at report generation time.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5564 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 19:53:46 +00:00
Michael Bayne 9a67119557 Added type to generateReport().
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5563 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 19:43:36 +00:00
Par Winzell 13c9f01b6e Go go invisible unicode characters.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5562 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 17:24:01 +00:00
Par Winzell 5d769cbf5f So, Flash CS4's internal compiler chokes on public class that implements an interface, when it's followed by faux-inner-classes after the main package declaration. This is the only workaround I can think of; pray god Adobe fixes their stuff soon and we can revert this irritating patch.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5561 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 15:14:29 +00:00
Jamie Doornbos 8c1faeb2a3 Robustification of bureau launching
* Track the exception that occurred, if any, when launching the bureau in each agent
* Guarantee agent object is always destroyed. This was probably also a memory leak.
* Destroy the agent object immediately if the launcher raised an exception rather than waiting for timeout

git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5560 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 00:42:46 +00:00
Michael Bayne 034284e103 Tuple.create -> Tuple.newTuple.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5559 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-18 21:15:43 +00:00
Michael Bayne 34fd5fda85 Test our streamable tuple changes.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5558 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-18 21:15:32 +00:00
Michael Bayne 1a6e705f81 Made "ant tests" compile and run the tests not just compile them.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5557 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-18 21:14:56 +00:00
Michael Bayne 792a5142cd Fortunately, Narya can magically set final fields behind the scenes, but we
need to first construct an instance with nulls. Also added newTuple(). Opted
not to make newStreamableTuple() as that would make more sense in a Tuples
class, but this method can only be accessed by calling StreamableTuple.newTuple
which seems to me to already tell the whole story.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5556 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-18 21:13:45 +00:00
Mike Thomas d14937991a Allow those using message bundles to get all the keys that start with a particular prefix, just like they can get all the translations that match a prefix.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5555 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-18 19:25:19 +00:00
Michael Bayne 201ab6adc7 Turn off the debug report for now.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5554 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-17 20:36:26 +00:00
Michael Bayne 37c14fe414 Depot now exports google-collect.jar for us.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5553 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-17 18:47:59 +00:00
Michael Bayne 0de7d59bdb Have narya depend on depot which depends on samskivert.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5552 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-17 18:46:23 +00:00
Michael Bayne d76d1678cf Find Depot in its new home.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5551 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-16 07:46:11 +00:00
Michael Bayne 40e9394817 Fix use of raw type.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5550 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-14 03:12:33 +00:00
Jamie Doornbos 79f5a17600 Oops, stray debug line got left in
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5549 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-14 01:51:28 +00:00
Jamie Doornbos 71af5514da Be nicely behaved if the user manages to close the client before the socket is opened
* Use _writer != null iff the socket is open and the authrequest has been sent
* Warn when posting messages prior to socket connect
* Clear the outgoing queue prior to sending the auth request, the servers authing connection expects this
* If a logoff is encountered prior to the socket opening, just shut down without sending auth request
* Driveby unused variable removal

This should fix the log warning "AuthingConnection$1: Received non-authreq message during authentication process"

git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5548 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-14 01:49:58 +00:00
Dave Hoover e1afaccd23 Cleanup some unused stuff & mark some overrides.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5547 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-12 18:46:06 +00:00
Michael Bayne 9c1e09f8ab Don't let a peer connection linger for 8 minutes before we time out it. If a
peer disconnects for any reason, end its session immediately.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5546 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-12 00:55:05 +00:00
Michael Bayne 8890583476 If we are asked to end a session after the omgr has shutdown, just log
something friendly and drop the request. The server is about to go away.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5545 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-12 00:54:37 +00:00
Michael Bayne ca2dc8dc4a Don't start our writer thread until we know our socket is connected and ready
to send data.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5544 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-12 00:32:54 +00:00
Michael Bayne c62cf6ba6f Don't start our tick interval until we've successfully logged on. There's no
utility in sending pings before we're authenticated.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5543 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-12 00:30:35 +00:00
Andrzej Kapolka a0a235e32a Import Transport if used in invocation method.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5542 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-11 20:38:08 +00:00
Michael Bayne c16731c8d1 Let's enforce that client reference copying with the structure of ObserverOps.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5541 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-11 19:09:42 +00:00
Jamie Doornbos 0f8c7d8f4c Get the trace for that pesky NPE in Client.Reader.receiveMessage
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5540 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-11 18:53:48 +00:00
Michael Bayne f4544ff76e Include current connection and handler count in our conmgr stats.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5539 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-11 18:47:58 +00:00
Jamie Doornbos 2014f8c906 Prevent calling observers with a null client
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5538 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-11 18:43:29 +00:00
Michael Bayne a0cc2fd348 Nixed the notion of a ConnectionObserver. The only observer was the
ClientManager and it is already pretty tightly coupled to the ConnectionManager
so we weren't really fooling anyone with that ham-fisted attempt at
abstraction.

Also cleaned up more mid-shutdown behavior. If a session is unmapped after the
omgr exits, avoid generating a warning by trying to hop onto the omgr thread to
clean up after ourselves. We still do all the actual socket related closing so
that the party on the other end of the socket benefits from a clean shutdown
where possible.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5537 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-11 01:52:29 +00:00