Commit Graph

5552 Commits

Author SHA1 Message Date
Jamie Doornbos 05afcd70d9 Moved a constant to the base class and replaced the hard-wiring there
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5615 542714f4-19e9-0310-aa3c-eee0fc999fb1
2009-01-04 07:14:54 +00:00
Jamie Doornbos eaa270be35 Stop java clients from queueing up ticks after logoff. This was sometimes causing a warning during shutdown.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5614 542714f4-19e9-0310-aa3c-eee0fc999fb1
2009-01-04 06:09:36 +00:00
Michael Bayne 581230b9a2 Operate on a snapshot of the overflow queue values as a connection may fail
while we're processing its overflow messages, which causes its overflow queue
to be cleared which causes a ConcurrentModificationException.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5613 542714f4-19e9-0310-aa3c-eee0fc999fb1
2009-01-03 00:41:53 +00:00
Michael Bayne b811f9e97f Enable unit profiling for great Whirled investigation.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5612 542714f4-19e9-0310-aa3c-eee0fc999fb1
2009-01-02 19:10:33 +00:00
Michael Bayne 7e0bd5c99a Drive by unwrapping.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5611 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-31 22:31:34 +00:00
Ray Greenwell 7728ed9bd3 Further cleanup: always look up streamers by their java name.
- Sliiiiightly less efficient in a few cases.
- But: looking typed arrays up by class didn't work anyway,
  there was some duplicated code in jname and class lookup,
  and the jname thing handles Lists from the server. So
  overall I think this is a win.
Less code is better code.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5610 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-31 00:41:20 +00:00
Ray Greenwell e9152193b7 - Just use dictionaries, which are inside the HashMaps anyway.
- Register Long.

(I could probably sweep through narya and re-jigger a bunch of
the actionscript code that was written while I was learning the
language.)


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5609 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-30 23:59:40 +00:00
Ray Greenwell e6ea84e5da Refactor to avoid linear lookup of streamers.
This was a bit of a rabbit hole and took longer than expected,
and I had a stupid bug that took a while to find,
but in the end there are way more lines of code removed than
added, so I'll call it a win. Streamer lookup is now via a Dictionary.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5608 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-30 23:25:50 +00:00
Ray Greenwell c7612ecb7d Apply Jamie's fix for negative numbers here on the actionscript side, too.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5607 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-30 20:25:51 +00:00
Ray Greenwell 9f920ae527 Added a note for Future Ray.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5606 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-19 22:13:24 +00:00
Ray Greenwell 7be46ee045 This all seems to work, so let's tidy it up.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5605 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-15 19:39:49 +00:00
Michael Bayne bb152eb27b Extract scheduleRegularReboot() into a method.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5604 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-12 23:50:20 +00:00
Michael Bayne c8e725d5e5 Log pong receipts as well.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5603 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-12 21:25:51 +00:00
Michael Bayne 91f1a3f893 Make the ping debugging optional since dev seems not to be failing now.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5602 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-12 20:41:19 +00:00
Par Winzell 8b177eea6f I didn't mean to commit that.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5601 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-12 16:06:18 +00:00
Par Winzell fb4a28b2ed Give Bureaus their own client object subclass. It does nothing at the moment, but we need it to be a distinct type for access control purposes.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5600 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-12 15:36:46 +00:00
Jamie Doornbos 1052aa86ec readUTF?
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5599 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 20:01:46 +00:00
Par Winzell 0cfc7fcc9e Turn debugging off again. Whew.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5598 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 19:53:16 +00:00
Par Winzell 31388566f6 Turn on streaming I/O debugging long enough to get better debugging data on the development server. Will be flipped back ASAP.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5597 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 19:35:25 +00:00
Michael Bayne 82da1521f3 I swear this was generating unchecked type warnings before, but it seems not to
be now.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5596 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 01:21:45 +00:00
Michael Bayne 47216207b3 Cleany cleany.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5595 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 01:12:51 +00:00
Michael Bayne f6f5a86db0 Here too.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5594 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 01:12:06 +00:00
Michael Bayne f2b30890f9 Fix longstanding annoyance with proxy subscriber access control checking. If
we're proxying for a client, we now have to give up our ClientObject to anyone
who wants it, so that they can do access control checks.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5593 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-11 01:11:04 +00:00
Ray Greenwell df5f5ace27 Cut client latency by attempting to send upstream messages
immediately.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5592 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 21:41:10 +00:00
Ray Greenwell 20b775a41b Teach 'ant genservice' to respect files with ActionScript(omit=true).
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5590 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 04:44:40 +00:00
Michael Bayne ec9e3331b9 Put some debugging in to see if we can figure out why the game server is
screwing the pooch on dev1.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5589 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 01:31:28 +00:00
Michael Bayne 4e01505dc5 We need the body here as well.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5588 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 01:05:49 +00:00
Ray Greenwell 7c979eb436 Logging varagification, associated stack traces.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5587 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 01:05:41 +00:00
Michael Bayne 49f2bdb493 Extract occupant info adding into an overridable method so that derived classes
can both participate in the combined event that adds an occupant's info and can
coordinate whether their info is added before or after.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5586 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-10 01:04:05 +00:00
Ray Greenwell a3e1c6e09e Fixup.
If there's an error when calling the callback function,
we were assuming it was an argument-related error and trying again.
However, this is sorta bad behavior as we don't want to call
twice into a callback. In the case I was seeing, the first time
in caused an NPE, but popped up a panel, and the second try
was no-opping because the panel was already up (but misconfigured).

So: don't even try a second call, because it looks like
flash will accept args to an argless function.
We'll have to try this out for a while and see if it works.
If so, I can neaten this code. If not, I'll uncomment
some of this and try a more surgical approach (only catch
ArgumentError, only retry if we had 1 boolean arg.)


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5585 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-09 23:23:15 +00:00
Par Winzell dc2c4e7793 Don't hardcode the TEXT data type; it'll still be chosen for use by MySQL and PostgreSQL because of the length of the field. Is 64k enough?
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5584 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-09 22:50:52 +00:00
Ray Greenwell 5f69af762d Reorder the args to these adapters: success is first now, followed by failure.
This has been wacked-out like this ever since I first wacked it out.
Since the base class is ResultAdapter and it only takes failure, and the
'processed' function for ConfirmAdapter is optional, it seemed to make
sense this way.
But, we have another ResultAdapter (for non-invocation ResultListener)
and it expects success first.
So Mike noticed this today (I swear there was a big brouhaha about this
over the summer) and beat me with my own rubber chicken.
I'm not sure why I had a mental block about reordering, but let's do it!


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5583 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-09 02:20:48 +00:00
Michael Bayne 343a2a7026 Nix unread variable.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5582 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-08 19:01:17 +00:00
Nathan Curtis 34d2833580 Enums can safely be used as Dictionary keys, and should therefore pass the isSimple() test.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5581 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-06 00:39:05 +00:00
Michael Bayne 92713ee4b8 Let's do our adding in a single event.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5580 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 22:03:04 +00:00
Michael Bayne 74bccd4223 Clean up occupant info creation and whatnot. Now we have a nice calldown method
bodyWillEnter() where the PlaceManager can do whatever they want when the body
enters, before or after the occupant info creation process.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5579 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 22:01:25 +00:00
Michael Bayne c793aff440 Unused import nixage.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5578 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 03:08:57 +00:00
Michael Bayne 12da80af98 Fix NameUpdater name.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5577 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 01:39:12 +00:00
Michael Bayne 6ece773295 NameUpdater not NameUpdate.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5576 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 01:38:40 +00:00
Michael Bayne 0942566fc3 Added a handy update for changing an occupant's name.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5575 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 01:31:30 +00:00
Michael Bayne c116f93a7b Fiddlesticks. Let's unify these update methods and do away entirely with the
old dangerous way of updating. We will now use only the timeless way.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5574 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-05 00:51:37 +00:00
Michael Bayne 62f393db95 Hold the phone. I already wrote this code. Sheesh.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5573 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-04 23:29:42 +00:00
Michael Bayne 420333df51 Made it easier to update occupant info the correct way in hopes of discouraging
people from updating it the wrong way.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5572 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-04 23:28:50 +00:00
Michael Bayne 46a5bbd0cc Don't cache our nodes query. We always want the latest and the freshest.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5571 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-12-02 21:58:50 +00:00
Dave Hoover 34ae8910d7 Widen & break one thing out so I can avoid copy & paste when I format
a very similar message in the yohoho reboot manager.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5570 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-27 00:30:48 +00:00
Michael Bayne 14307d7292 Break out communicator creation into an overridable method temporarily.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5569 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-26 23:57:17 +00:00
Jamie Doornbos adf11c5381 Fixed index out of bounds exception. This was causing msoy aux reporters to never complete if the report type was not registered on the game server (e.g. servlet ony)
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5568 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-24 23:01:16 +00:00
Mike Thomas a5b8aad082 Prevent a divide by zero that we're seeing occasionally on startup.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5567 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-21 00:22:51 +00:00
Ray Greenwell e649880f90 Allow a message to be passed to happy testing dumpStack()
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5566 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-20 19:48:47 +00:00
Ray Greenwell 7b9c0501a6 Added no-args generateReport() to generate default report.
There is a registerReporter() that doesn't take a type, so this
seemed like the way to go, rather than changing msoy to
pass in DEFAULT_TYPE.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5565 542714f4-19e9-0310-aa3c-eee0fc999fb1
2008-11-19 21:15:39 +00:00