AfflictionNetworks/vilya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use an ArrayIntSet instead of a HashSet<Integer> as it's way more memory

Browse Source 
efficient (and almost certainly faster as well for sets of this size).

Modified add() to properly mark the stat as modified when it changes.


git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@668 c613c5cb-e716-0410-b11b-feb51c14d237
This commit is contained in:
Michael Bayne
2008-07-18 13:21:15 +00:00
parent 74d08d334f
commit faa237b85d
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/stats/data/IntSetStat.java
+7 -4
View File
@@ -4,8 +4,9 @@
package com.threerings.stats.data; package com.threerings.stats.data;
import java.io.IOException; import java.io.IOException;
import java.util.HashSet;
import com.samskivert.util.ArrayIntSet;
import com.samskivert.util.IntSet;
import com.samskivert.util.StringUtil; import com.samskivert.util.StringUtil;
import com.threerings.io.ObjectInputStream; import com.threerings.io.ObjectInputStream;
import com.threerings.io.ObjectOutputStream; import com.threerings.io.ObjectOutputStream;
@@ -57,7 +58,9 @@ public class IntSetStat extends Stat
*/ */
public boolean add (int key) public boolean add (int key)
{ {
return (_intSet.size() < _maxSize ? _intSet.add(key) : false); boolean modified = (_intSet.size() < _maxSize) && _intSet.add(key);
setModified(_modified || modified);
return modified;
} }
@Override @Override
@@ -77,7 +80,7 @@ public class IntSetStat extends Stat
{ {
_maxSize = ((int)in.readByte()) + 128; _maxSize = ((int)in.readByte()) + 128;
int numValues = ((int)in.readByte()) + 128; int numValues = ((int)in.readByte()) + 128;
_intSet = new HashSet<Integer>(numValues); _intSet = new ArrayIntSet(numValues);
for (int ii = 0; ii < numValues; ii++) { for (int ii = 0; ii < numValues; ii++) {
_intSet.add(in.readInt()); _intSet.add(in.readInt());
} }
@@ -91,7 +94,7 @@ public class IntSetStat extends Stat
} }
protected int _maxSize; protected int _maxSize;
protected HashSet<Integer> _intSet = new HashSet<Integer>(); protected IntSet _intSet = new ArrayIntSet();
protected static final int MAX_MAX_SIZE = 255; protected static final int MAX_MAX_SIZE = 255;