From f139e30daa2d2d512c816dce19a68032c9392091 Mon Sep 17 00:00:00 2001 From: Michael Bayne Date: Mon, 29 Jan 2007 18:07:33 +0000 Subject: [PATCH] Annouce a player's game over *in* playerGameDidEnd() rather than after because a natural thing to do in playerGameDidEnd() is replacePlayer() the departed player with an AI but if we wait until after playerGameDidEnd() to announce it, we end up announcing the departure of the newly configured AI. git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@161 c613c5cb-e716-0410-b11b-feb51c14d237 --- src/java/com/threerings/parlor/game/server/GameManager.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/java/com/threerings/parlor/game/server/GameManager.java b/src/java/com/threerings/parlor/game/server/GameManager.java index 0ed3e252..825a8178 100644 --- a/src/java/com/threerings/parlor/game/server/GameManager.java +++ b/src/java/com/threerings/parlor/game/server/GameManager.java @@ -495,8 +495,6 @@ public class GameManager extends PlaceManager // let derived classes do some business playerGameDidEnd(pidx); - announcePlayerGameOver(pidx); - } finally { _gameobj.commitTransaction(); } @@ -1103,6 +1101,8 @@ public class GameManager extends PlaceManager */ protected void playerGameDidEnd (int pidx) { + // report that the player's game is over to anyone still in the game room + announcePlayerGameOver(pidx); } /**