Prune trailing whitespace & foreachize loops.

git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@840 c613c5cb-e716-0410-b11b-feb51c14d237

src/java/com/threerings/micasa/lobby/LobbyRegistry.java

@@ -114,8 +114,8 @@ public class LobbyRegistry
         if (lmgrs == null || lmgrs.length == 0) {
             log.warning("No lobbies specified in config file (via '" + LOBIDS_KEY + "' parameter).");
         } else {
-            for (int i = 0; i < lmgrs.length; i++) {
+            for (String lmgr : lmgrs) {
-                loadLobby(lmgrs[i]);
+                loadLobby(lmgr);
             }
         }
     }

src/java/com/threerings/parlor/data/Table.java

@@ -376,8 +376,8 @@ public class Table
             int[][] teams = tconfig.teamMemberIndices;
             for (int[] team : teams) {
                 int teamCount = 0;
-                for (int jj=0; jj < team.length; jj++) {
+                for (int element : team) {
-                    if (players[team[jj]] != null) {
+                    if (players[element] != null) {
                         teamCount++;
                     }
                 }

src/java/com/threerings/parlor/server/TableManager.java

@@ -355,9 +355,9 @@ public class TableManager
 
         // clear out all matching entries in the boid map
         if (table.bodyOids != null) {
-            for (int ii = 0; ii < table.bodyOids.length; ii++) {
+            for (int bodyOid : table.bodyOids) {
-                if (table.bodyOids[ii] != 0) {
+                if (bodyOid != 0) {
-                    notePlayerRemoved(table.bodyOids[ii]);
+                    notePlayerRemoved(bodyOid);
                 }
             }
         }
@@ -471,9 +471,9 @@ public class TableManager
 
         if (table.bodyOids != null) {
             // clear the player to table mappings as this game is underway
-            for (int ii = 0; ii < table.bodyOids.length; ii++) {
+            for (int bodyOid : table.bodyOids) {
-                if (table.bodyOids[ii] != 0) {
+                if (bodyOid != 0) {
-                    notePlayerRemoved(table.bodyOids[ii]);
+                    notePlayerRemoved(bodyOid);
                 }
             }
         }

src/java/com/threerings/stage/data/ModifyObjectsUpdate.java

@@ -63,15 +63,15 @@ public class ModifyObjectsUpdate extends SceneUpdate
 
         // wipe out the objects that need to go
         if (removed != null) {
-            for (int ii = 0; ii < removed.length; ii++) {
+            for (ObjectInfo element : removed) {
-                mmodel.removeObject(removed[ii]);
+                mmodel.removeObject(element);
             }
         }
 
         // add the new objects
         if (added != null) {
-            for (int ii = 0; ii < added.length; ii++) {
+            for (ObjectInfo element : added) {
-                mmodel.addObject(added[ii]);
+                mmodel.addObject(element);
             }
         }
     }

src/java/com/threerings/stage/data/StageMisoSceneModel.java

@@ -55,9 +55,9 @@ public class StageMisoSceneModel extends SparseMisoSceneModel
      */
     public static StageMisoSceneModel getSceneModel (SceneModel model)
     {
-        for (int ii = 0; ii < model.auxModels.length; ii++) {
+        for (AuxModel auxModel : model.auxModels) {
-            if (model.auxModels[ii] instanceof StageMisoSceneModel) {
+            if (auxModel instanceof StageMisoSceneModel) {
-                return (StageMisoSceneModel)model.auxModels[ii];
+                return (StageMisoSceneModel)auxModel;
             }
         }
         return null;

src/java/com/threerings/stage/tools/viewer/ViewerFrame.java

@@ -162,8 +162,7 @@ public class ViewerFrame extends ManagedJFrame
                 SpotSceneModel ssmodel = SpotSceneModel.getSceneModel(model);
                 Location defloc = null;
                 // find the default entrance to this scene
-                for (int ii = 0; ii < ssmodel.portals.length; ii++) {
+                for (Portal port : ssmodel.portals) {
-                    Portal port = ssmodel.portals[ii];
                     if (port.portalId == ssmodel.defaultEntranceId) {
                         defloc = port.getOppLocation();
                         break;

src/java/com/threerings/stage/tools/viewer/ViewerScenePanel.java

@@ -64,10 +64,8 @@ public class ViewerScenePanel extends StageScenePanel
         _charmgr = charmgr;
 
         // create the character descriptors
-        _descUser = CastUtil.getRandomDescriptor(
+        _descUser = CastUtil.getRandomDescriptor("female", ctx.getComponentRepository());
-            "female", ctx.getComponentRepository());
+        _descDecoy = CastUtil.getRandomDescriptor("male", ctx.getComponentRepository());
-        _descDecoy = CastUtil.getRandomDescriptor(
-            "male", ctx.getComponentRepository());
 
         // create the manipulable sprite
         _sprite = createSprite(_descUser);
@@ -87,8 +85,8 @@ public class ViewerScenePanel extends StageScenePanel
         _sprite.setLocation(defpos.x, defpos.y);
 
         if (_decoys != null) {
-            for (int ii = 0; ii < _decoys.length; ii++) {
+            for (CharacterSprite decoy : _decoys) {
-                _decoys[ii].setLocation(defpos.x, defpos.y);
+                decoy.setLocation(defpos.x, defpos.y);
             }
             createDecoyPaths();
         }
@@ -144,9 +142,9 @@ public class ViewerScenePanel extends StageScenePanel
     protected void createDecoyPaths ()
     {
         if (_decoys != null) {
-            for (int ii = 0; ii < _decoys.length; ii++) {
+            for (CharacterSprite decoy : _decoys) {
-                if (_decoys[ii] != null) {
+                if (decoy != null) {
-                    createRandomPath(_decoys[ii]);
+                    createRandomPath(decoy);
                 }
             }
         }
@@ -177,8 +175,8 @@ public class ViewerScenePanel extends StageScenePanel
 
         case MouseEvent.BUTTON2_MASK:
             if (_decoys != null) {
-                for (int ii = 0; ii < _decoys.length; ii++) {
+                for (CharacterSprite decoy : _decoys) {
-                    createPath(_decoys[ii], x, y);
+                    createPath(decoy, x, y);
                 }
             }
             break;

src/java/com/threerings/stage/tools/xml/StageSceneWriter.java

@@ -66,11 +66,11 @@ public class StageSceneWriter extends SceneWriter
         if (sscene.defaultColors != null) {
             writer.startElement("zations");
             int[] keys = sscene.defaultColors.getKeys();
-            for (int ii=0, nn=keys.length; ii < nn; ii++) {
+            for (int key : keys) {
-                int value = sscene.defaultColors.get(keys[ii]);
+                int value = sscene.defaultColors.get(key);
                 AttributesImpl attrs = new AttributesImpl();
                 attrs.addAttribute("", "classId", "", "",
-                                   String.valueOf(keys[ii]));
+                                   String.valueOf(key));
                 attrs.addAttribute("", "colorId", "", "",
                                    String.valueOf(value));
                 writer.emptyElement("", "zation", "", attrs);

src/java/com/threerings/stats/data/ByteStringSetStat.java

@@ -36,8 +36,8 @@ public class ByteStringSetStat extends StringSetStat
         throws IOException
     {
         out.writeByte(_values.length);
-        for (int ii = 0; ii < _values.length; ii++) {
+        for (String value : _values) {
-            out.writeByte((byte)aux.getStringCode(_type, _values[ii]));
+            out.writeByte((byte)aux.getStringCode(_type, value));
         }
     }
 

src/java/com/threerings/stats/data/IntStringSetStat.java

@@ -36,8 +36,8 @@ public class IntStringSetStat extends StringSetStat
         throws IOException
     {
         out.writeInt(_values.length);
-        for (int ii = 0; ii < _values.length; ii++) {
+        for (String value : _values) {
-            out.writeInt(aux.getStringCode(_type, _values[ii]));
+            out.writeInt(aux.getStringCode(_type, value));
         }
     }
 

src/java/com/threerings/stats/data/ShortStringSetStat.java

@@ -36,8 +36,8 @@ public class ShortStringSetStat extends StringSetStat
         throws IOException
     {
         out.writeShort(_values.length);
-        for (int ii = 0; ii < _values.length; ii++) {
+        for (String value : _values) {
-            out.writeShort((short)aux.getStringCode(_type, _values[ii]));
+            out.writeShort((short)aux.getStringCode(_type, value));
         }
     }
 

src/java/com/threerings/whirled/spot/tools/xml/SpotSceneWriter.java

@@ -31,6 +31,7 @@ import com.megginson.sax.DataWriter;
 import com.threerings.tools.xml.NestableWriter;
 
 import com.threerings.whirled.spot.data.Location;
+import com.threerings.whirled.spot.data.Portal;
 import com.threerings.whirled.spot.data.SpotSceneModel;
 import com.threerings.whirled.spot.tools.EditablePortal;
 
@@ -70,8 +71,8 @@ public class SpotSceneWriter
         throws SAXException
     {
         // write out the portal info
-        for (int ii = 0; ii < model.portals.length; ii++) {
+        for (Portal portal : model.portals) {
-            EditablePortal port = (EditablePortal)model.portals[ii];
+            EditablePortal port = (EditablePortal)portal;
             AttributesImpl attrs = new AttributesImpl();
             attrs.addAttribute("", "portalId", "", "",
                                String.valueOf(port.portalId));
@@ -90,13 +91,13 @@ public class SpotSceneWriter
         // more sophisticated could be done
         Class<?> clazz = portalLoc.getClass();
         Field[] fields = clazz.getFields();
-        for (int ii=0; ii < fields.length; ii++) {
+        for (Field field : fields) {
             try {
-                attrs.addAttribute("", fields[ii].getName(), "", "",
+                attrs.addAttribute("", field.getName(), "", "",
-                    String.valueOf(fields[ii].get(portalLoc)));
+                    String.valueOf(field.get(portalLoc)));
             } catch (IllegalAccessException iae) {
                 log.warning("Unable to write portal field, skipping " +
-                    "[field=" + fields[ii].getName() + ", e=" + iae + "].");
+                    "[field=" + field.getName() + ", e=" + iae + "].");
             }
         }
     }