Drive-by logging varargification.

git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@817 c613c5cb-e716-0410-b11b-feb51c14d237

src/as/com/threerings/parlor/client/Invitation.as

@@ -175,11 +175,8 @@ public class Invitation
             }
 
         } catch (e :Error) {
-            var log :Log = Log.getLog(this);
+            Log.getLog(this).warning("Invitation response observer choked on response",
-            log.warning("Invitation response observer choked on response " +
+                "code", code, "arg", arg, "invite", this, e);
-                        "[code=" + code + ", arg=" + arg +
-                        ", invite=" + this + "].");
-            log.logStackTrace(e);
         }
 
         // unless the invitation was countered, we can remove it from the

src/as/com/threerings/parlor/client/ParlorDirector.as

@@ -139,7 +139,7 @@ public class ParlorDirector extends BasicDirector
     // documentation inherited from interface
     public function gameIsReady (gameOid :int) :void
     {
-        _log.info("Handling game ready [goid=" + gameOid + "].");
+        _log.info("Handling game ready", "goid", gameOid);
 
         // see what our observers have to say about it
         var handled :Boolean = false;
@@ -170,8 +170,7 @@ public class ParlorDirector extends BasicDirector
             _handler.invitationReceived(invite);
 
         } catch (err :Error) {
-            _log.warning("Invitation handler choked on invite notification " + invite + ".");
+            _log.warning("Invitation handler choked on invite notification", "invite", invite, err);
-            _log.logStackTrace(err);
         }
     }
 
@@ -181,8 +180,8 @@ public class ParlorDirector extends BasicDirector
         // look up the invitation record for this invitation
         var invite :Invitation = (_pendingInvites.get(remoteId) as Invitation);
         if (invite == null) {
-            _log.warning("Have no record of invitation for which we received a response?! " +
+            _log.warning("Have no record of invitation for which we received a response?!",
-                         "[remoteId=" + remoteId + ", code=" + code + ", arg=" + arg + "].");
+                "remoteId", remoteId, "code", code, "arg", arg);
         } else {
             invite.receivedResponse(code, arg);
         }

src/as/com/threerings/parlor/client/TableDirector.as

@@ -185,15 +185,15 @@ public class TableDirector extends BasicDirector
     {
         // if we're already in a table, refuse the request
         if (_ourTable != null) {
-            log.warning("Ignoring request to create table as we're " +
+            log.warning("Ignoring request to create table as we're already in a table",
-                        "already in a table [table=" + _ourTable + "].");
+                "table", _ourTable);
             return;
         }
 
         // make sure we're currently in a place
         if (_tlobj == null) {
-            log.warning("Requested to create a table but we're not " +
+            log.warning("Requested to create a table but we're not currently in a place",
-                        "currently in a place [config=" + config + "].");
+                "config", config);
             return;
         }
 
@@ -209,20 +209,20 @@ public class TableDirector extends BasicDirector
     {
         // if we're already in a table, refuse the request
         if (_ourTable != null) {
-            log.warning("Ignoring request to join table as we're " +
+            log.warning("Ignoring request to join table as we're already in a table",
-                        "already in a table [table=" + _ourTable + "].");
+                "table", _ourTable);
             return;
         }
 
         // make sure we're currently in a place
         if (_tlobj == null) {
-            log.warning("Requested to join a table but we're not " +
+            log.warning("Requested to join a table but we're not currently in a place",
-                        "currently in a place [tableId=" + tableId + "].");
+                "tableId", tableId);
             return;
         }
 
         // issue the join request
-        log.info("Joining table [tid=" + tableId + ", pos=" + position + "].");
+        log.info("Joining table", "tid", tableId, "pos", position);
         _tlobj.getTableService().joinTable(_pctx.getClient(), tableId, position, this);
     }
 
@@ -234,8 +234,8 @@ public class TableDirector extends BasicDirector
     {
         // make sure we're currently in a place
         if (_tlobj == null) {
-            log.warning("Requested to leave a table but we're not " +
+            log.warning("Requested to leave a table but we're not currently in a place",
-                        "currently in a place [tableId=" + tableId + "].");
+                "tableId", tableId);
             return;
         }
 
@@ -250,8 +250,8 @@ public class TableDirector extends BasicDirector
     public function startTableNow (tableId :int) :void
     {
         if (_tlobj == null) {
-            log.warning("Requested to start a table but we're not " +
+            log.warning("Requested to start a table but we're not currently in a place",
-                        "currently in a place [tableId=" + tableId + "].");
+                "tableId", tableId);
             return;
         }
 
@@ -264,8 +264,8 @@ public class TableDirector extends BasicDirector
     public function bootPlayer (tableId :int, target :Name) :void
     {
         if (_tlobj == null) {
-            log.warning("Requesting to boot a player from a table we're not currently in " +
+            log.warning("Requesting to boot a player from a table we're not currently in",
-                        "[tableId=" + tableId + ", target=" + target + "].");
+                "tableId", tableId, "target", target);
             return;
         }
 
@@ -336,13 +336,13 @@ public class TableDirector extends BasicDirector
         var tableId :int = int(result);
         if (_tlobj == null) {
             // we've left, it's none of our concern anymore
-            log.info("Table created, but no lobby. [tableId=" + tableId + "].");
+            log.info("Table created, but no lobby.", "tableId", tableId);
             return;
         }
 
         var table :Table = (_tlobj.getTables().get(tableId) as Table);
         if (table == null) {
-            log.warning("Table created, but where is it? [tableId=" + tableId + "]");
+            log.warning("Table created, but where is it?", "tableId", tableId);
             return;
         }