From 74d08d334f8d787f9f5aea86c47ffcfba87ca058 Mon Sep 17 00:00:00 2001 From: Michael Bayne Date: Fri, 18 Jul 2008 13:15:38 +0000 Subject: [PATCH] Use setModified() instead of modifying our value directly. That way it can be overridden to intercept such things if necessary (it's not necesary in this case, we're just trying to set a good example for future programmers). git-svn-id: svn+ssh://src.earth.threerings.net/vilya/trunk@667 c613c5cb-e716-0410-b11b-feb51c14d237 --- src/java/com/threerings/stats/data/IntArrayStat.java | 4 ++-- src/java/com/threerings/stats/data/IntStat.java | 2 +- src/java/com/threerings/stats/data/StringMapStat.java | 4 ++-- src/java/com/threerings/stats/data/StringSetStat.java | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/java/com/threerings/stats/data/IntArrayStat.java b/src/java/com/threerings/stats/data/IntArrayStat.java index 3560d2b0..0e680f2b 100644 --- a/src/java/com/threerings/stats/data/IntArrayStat.java +++ b/src/java/com/threerings/stats/data/IntArrayStat.java @@ -35,7 +35,7 @@ public class IntArrayStat extends Stat { if (!Arrays.equals(_value, value)) { _value = value; - _modified = true; + setModified(true); return true; } return false; @@ -47,7 +47,7 @@ public class IntArrayStat extends Stat public void appendValue (int value) { _value = ArrayUtil.append(_value, value); - _modified = true; + setModified(true); } @Override // documentation inherited diff --git a/src/java/com/threerings/stats/data/IntStat.java b/src/java/com/threerings/stats/data/IntStat.java index dd06c90b..65f95feb 100644 --- a/src/java/com/threerings/stats/data/IntStat.java +++ b/src/java/com/threerings/stats/data/IntStat.java @@ -30,7 +30,7 @@ public class IntStat extends Stat { if (value != _value) { _value = value; - _modified = true; + setModified(true); return true; } return false; diff --git a/src/java/com/threerings/stats/data/StringMapStat.java b/src/java/com/threerings/stats/data/StringMapStat.java index b1930af2..b52a63a2 100644 --- a/src/java/com/threerings/stats/data/StringMapStat.java +++ b/src/java/com/threerings/stats/data/StringMapStat.java @@ -47,7 +47,7 @@ public abstract class StringMapStat extends Stat int ovalue = _values[iidx]; _values[iidx] = Math.min(value, getMaxValue()); if (_values[iidx] != ovalue) { - _modified = true; + setModified(true); return true; } return false; @@ -67,7 +67,7 @@ public abstract class StringMapStat extends Stat int ovalue = _values[iidx]; _values[iidx] = Math.min(_values[iidx] + amount, getMaxValue()); if (_values[iidx] != ovalue) { - _modified = true; + setModified(true); return true; } return false; diff --git a/src/java/com/threerings/stats/data/StringSetStat.java b/src/java/com/threerings/stats/data/StringSetStat.java index 8fb259f4..d8a83e79 100644 --- a/src/java/com/threerings/stats/data/StringSetStat.java +++ b/src/java/com/threerings/stats/data/StringSetStat.java @@ -45,7 +45,7 @@ public abstract class StringSetStat extends Stat System.arraycopy(_values, iidx, values, iidx+1, (_values.length-iidx)); values[iidx] = key; _values = values; - _modified = true; + setModified(true); return true; }