diff --git a/src/java/com/threerings/micasa/lobby/LobbySelector.java b/src/java/com/threerings/micasa/lobby/LobbySelector.java index dc0e9dda..b234444b 100644 --- a/src/java/com/threerings/micasa/lobby/LobbySelector.java +++ b/src/java/com/threerings/micasa/lobby/LobbySelector.java @@ -21,7 +21,6 @@ package com.threerings.micasa.lobby; -import java.util.HashMap; import java.util.List; import java.util.Map; @@ -39,6 +38,8 @@ import javax.swing.JComboBox; import javax.swing.JList; import javax.swing.JPanel; +import com.google.common.collect.Maps; + import com.threerings.crowd.data.PlaceObject; import com.threerings.micasa.util.MiCasaContext; @@ -119,8 +120,8 @@ public class LobbySelector extends JPanel public void gotCategories (String[] categories) { // append these to our "unselected" item - for (int i = 0; i < categories.length; i++) { - _combo.addItem(categories[i]); + for (String categorie : categories) { + _combo.addItem(categorie); } } @@ -222,7 +223,7 @@ public class LobbySelector extends JPanel protected JComboBox _combo; protected JList _loblist; - protected Map _catlists = new HashMap(); + protected Map _catlists = Maps.newHashMap(); protected String _pendingCategory; protected static final String CAT_FIRST_ITEM = ""; diff --git a/src/java/com/threerings/micasa/simulator/server/SimulatorManager.java b/src/java/com/threerings/micasa/simulator/server/SimulatorManager.java index e82525e9..1142ad9c 100644 --- a/src/java/com/threerings/micasa/simulator/server/SimulatorManager.java +++ b/src/java/com/threerings/micasa/simulator/server/SimulatorManager.java @@ -21,9 +21,9 @@ package com.threerings.micasa.simulator.server; -import java.util.ArrayList; import java.util.List; +import com.google.common.collect.Lists; import com.google.inject.Inject; import com.google.inject.Singleton; @@ -174,7 +174,7 @@ public class SimulatorManager } /** The simulant body objects. */ - protected List _sims = new ArrayList(); + protected List _sims = Lists.newArrayList(); /** The game object for the game being created. */ protected GameObject _gobj; diff --git a/src/java/com/threerings/parlor/card/client/CardPanel.java b/src/java/com/threerings/parlor/card/client/CardPanel.java index 7a5e7376..efec2ae6 100644 --- a/src/java/com/threerings/parlor/card/client/CardPanel.java +++ b/src/java/com/threerings/parlor/card/client/CardPanel.java @@ -34,6 +34,8 @@ import java.awt.event.MouseEvent; import javax.swing.event.MouseInputAdapter; +import com.google.common.collect.Lists; + import com.samskivert.util.ObserverList; import com.samskivert.util.Predicate; import com.samskivert.util.QuickSort; @@ -259,8 +261,8 @@ public abstract class CardPanel extends VirtualMediaPanel public void clearHandSelection () { CardSprite[] sprites = getSelectedHandSprites(); - for (int i = 0; i < sprites.length; i++) { - deselectHandSprite(sprites[i]); + for (CardSprite sprite : sprites) { + deselectHandSprite(sprite); } } @@ -394,11 +396,11 @@ public abstract class CardPanel extends VirtualMediaPanel { // fly each sprite over, removing it from the hand immediately and from the board when it // finishes its path - for (int i = 0; i < cards.length; i++) { - removeFromHand(cards[i]); + for (CardSprite card : cards) { + removeFromHand(card); LinePath flight = new LinePath(dest, flightDuration); - cards[i].addSpriteObserver(_pathEndRemover); - cards[i].moveAndFadeOut(flight, flightDuration, fadePortion); + card.addSpriteObserver(_pathEndRemover); + card.moveAndFadeOut(flight, flightDuration, fadePortion); } // adjust the hand to cover the hole @@ -433,21 +435,21 @@ public abstract class CardPanel extends VirtualMediaPanel // then set the layers and fly the cards in int size = _handSprites.size(); - for (int i = 0; i < sprites.length; i++) { - int idx = _handSprites.indexOf(sprites[i]); - sprites[i].setLocation(src.x, src.y); - sprites[i].setRenderOrder(idx); - sprites[i].addSpriteObserver(_handSpriteObserver); - addSprite(sprites[i]); + for (CardSprite sprite : sprites) { + int idx = _handSprites.indexOf(sprite); + sprite.setLocation(src.x, src.y); + sprite.setRenderOrder(idx); + sprite.addSpriteObserver(_handSpriteObserver); + addSprite(sprite); // create a path sequence containing flight, pause, and drop - ArrayList paths = new ArrayList(); + ArrayList paths = Lists.newArrayList(); Point hp2 = new Point(getHandX(size, idx), _handLocation.y), hp1 = new Point(hp2.x, hp2.y - _selectedCardOffset); paths.add(new LinePath(hp1, flightDuration)); paths.add(new LinePath(hp1, pauseDuration)); paths.add(new LinePath(hp2, dropDuration)); - sprites[i].moveAndFadeIn(new PathSequence(paths), flightDuration + + sprite.moveAndFadeIn(new PathSequence(paths), flightDuration + pauseDuration + dropDuration, fadePortion); } } @@ -587,11 +589,11 @@ public abstract class CardPanel extends VirtualMediaPanel public void flyFromBoard (CardSprite[] cards, Point dest, long flightDuration, float fadePortion) { - for (int i = 0; i < cards.length; i++) { + for (CardSprite card : cards) { LinePath flight = new LinePath(dest, flightDuration); - cards[i].addSpriteObserver(_pathEndRemover); - cards[i].moveAndFadeOut(flight, flightDuration, fadePortion); - _boardSprites.remove(cards[i]); + card.addSpriteObserver(_pathEndRemover); + card.moveAndFadeOut(flight, flightDuration, fadePortion); + _boardSprites.remove(card); } } @@ -608,13 +610,13 @@ public abstract class CardPanel extends VirtualMediaPanel public void flyFromBoard (CardSprite[] cards, Point dest1, Point dest2, long flightDuration, float fadePortion) { - for (int i = 0; i < cards.length; i++) { + for (CardSprite card : cards) { PathSequence flight = new PathSequence( new LinePath(dest1, flightDuration/2), new LinePath(dest1, dest2, flightDuration/2)); - cards[i].addSpriteObserver(_pathEndRemover); - cards[i].moveAndFadeOut(flight, flightDuration, fadePortion); - _boardSprites.remove(cards[i]); + card.addSpriteObserver(_pathEndRemover); + card.moveAndFadeOut(flight, flightDuration, fadePortion); + _boardSprites.remove(card); } } @@ -1072,11 +1074,10 @@ public abstract class CardPanel extends VirtualMediaPanel protected CardSprite _activeCardSprite; /** The sprites for cards within the hand. */ - protected ArrayList _handSprites = new ArrayList(); + protected ArrayList _handSprites = Lists.newArrayList(); /** The sprites for cards within the hand that have been selected. */ - protected ArrayList _selectedHandSprites = - new ArrayList(); + protected ArrayList _selectedHandSprites = Lists.newArrayList(); /** The current selection mode for the hand. */ protected int _handSelectionMode; @@ -1103,7 +1104,7 @@ public abstract class CardPanel extends VirtualMediaPanel protected int _selectedCardOffset; /** The sprites for cards on the board. */ - protected ArrayList _boardSprites = new ArrayList(); + protected ArrayList _boardSprites = Lists.newArrayList(); /** The hand sprite observer instance. */ protected HandSpriteObserver _handSpriteObserver = new HandSpriteObserver(); diff --git a/src/java/com/threerings/parlor/card/trick/server/TrickCardGameManagerDelegate.java b/src/java/com/threerings/parlor/card/trick/server/TrickCardGameManagerDelegate.java index 30dbab2a..8f488257 100644 --- a/src/java/com/threerings/parlor/card/trick/server/TrickCardGameManagerDelegate.java +++ b/src/java/com/threerings/parlor/card/trick/server/TrickCardGameManagerDelegate.java @@ -21,10 +21,11 @@ package com.threerings.parlor.card.trick.server; -import java.util.ArrayList; import java.util.Arrays; import java.util.List; +import com.google.common.collect.Lists; + import com.samskivert.util.ArrayUtil; import com.samskivert.util.Interval; import com.samskivert.util.RandomUtil; @@ -451,7 +452,7 @@ public class TrickCardGameManagerDelegate extends TurnGameManagerDelegate */ protected Card pickRandomPlayableCard (Hand hand) { - List playableCards = new ArrayList(); + List playableCards = Lists.newArrayList(); for (int i = 0; i < hand.size(); i++) { Card card = hand.get(i); if (_trickCardGame.isCardPlayable(hand, card)) { diff --git a/src/java/com/threerings/parlor/data/Table.java b/src/java/com/threerings/parlor/data/Table.java index 229eafd4..c66ddb71 100644 --- a/src/java/com/threerings/parlor/data/Table.java +++ b/src/java/com/threerings/parlor/data/Table.java @@ -25,6 +25,7 @@ import java.util.HashSet; import java.util.List; import com.google.common.collect.Lists; +import com.google.common.collect.Sets; import com.samskivert.util.ArrayIntSet; import com.samskivert.util.ListUtil; @@ -129,8 +130,8 @@ public class Table @ActionScript(omit=true) public boolean isEmpty () { - for (int i = 0; i < bodyOids.length; i++) { - if (bodyOids[i] != 0) { + for (int bodyOid : bodyOids) { + if (bodyOid != 0) { return false; } } @@ -144,8 +145,8 @@ public class Table { int count = 0; if (players != null) { - for (int ii = 0; ii < players.length; ii++) { - if (players[ii] != null) { + for (Name player : players) { + if (player != null) { count++; } } @@ -270,7 +271,7 @@ public class Table public void addBannedUser (Name player) { if (_bannedUsers == null) { - _bannedUsers = new HashSet(); + _bannedUsers = Sets.newHashSet(); } _bannedUsers.add(player); @@ -373,10 +374,10 @@ public class Table } else { // for a team game, make sure each team has the minimum players int[][] teams = tconfig.teamMemberIndices; - for (int ii=0; ii < teams.length; ii++) { + for (int[] team : teams) { int teamCount = 0; - for (int jj=0; jj < teams[ii].length; jj++) { - if (players[teams[ii][jj]] != null) { + for (int jj=0; jj < team.length; jj++) { + if (players[team[jj]] != null) { teamCount++; } } diff --git a/src/java/com/threerings/parlor/game/data/GameConfig.java b/src/java/com/threerings/parlor/game/data/GameConfig.java index 9d089519..2c9a51b2 100644 --- a/src/java/com/threerings/parlor/game/data/GameConfig.java +++ b/src/java/com/threerings/parlor/game/data/GameConfig.java @@ -21,9 +21,10 @@ package com.threerings.parlor.game.data; -import java.util.ArrayList; import java.util.List; +import com.google.common.collect.Lists; + import com.threerings.util.Name; import com.threerings.crowd.data.PlaceConfig; @@ -121,7 +122,7 @@ public abstract class GameConfig extends PlaceConfig */ public List getDescription () { - return new ArrayList(); // nothing by default + return Lists.newArrayList(); // nothing by default } /** diff --git a/src/java/com/threerings/parlor/rating/server/persist/RatingRepository.java b/src/java/com/threerings/parlor/rating/server/persist/RatingRepository.java index d554709d..d959c3c9 100644 --- a/src/java/com/threerings/parlor/rating/server/persist/RatingRepository.java +++ b/src/java/com/threerings/parlor/rating/server/persist/RatingRepository.java @@ -99,7 +99,7 @@ public class RatingRepository extends DepotRepository */ public List getRatings (int playerId, long since, int count) { - ArrayList clauses = new ArrayList(); + ArrayList clauses = Lists.newArrayList(); if (since > 0L) { Timestamp when = new Timestamp(System.currentTimeMillis() - since); clauses.add(new Where(new And(new Equals(RatingRecord.PLAYER_ID, playerId), diff --git a/src/java/com/threerings/parlor/tourney/server/persist/TourneyRepository.java b/src/java/com/threerings/parlor/tourney/server/persist/TourneyRepository.java index e2cba78f..e6835eae 100644 --- a/src/java/com/threerings/parlor/tourney/server/persist/TourneyRepository.java +++ b/src/java/com/threerings/parlor/tourney/server/persist/TourneyRepository.java @@ -30,6 +30,7 @@ import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; +import com.google.common.collect.Lists; import com.google.inject.Inject; import com.google.inject.Singleton; @@ -146,7 +147,7 @@ public class TourneyRepository extends JORARepository throws PersistenceException { ArrayList recordList = loadAll(_ttable, ""); - ArrayList configList = new ArrayList(recordList.size()); + ArrayList configList = Lists.newArrayListWithCapacity(recordList.size()); for (TourneyRecord record : recordList) { configList.add(record.getTourneyConfig()); } diff --git a/src/java/com/threerings/parlor/turn/client/TurnDisplay.java b/src/java/com/threerings/parlor/turn/client/TurnDisplay.java index b86bd629..43ab1fcd 100644 --- a/src/java/com/threerings/parlor/turn/client/TurnDisplay.java +++ b/src/java/com/threerings/parlor/turn/client/TurnDisplay.java @@ -31,6 +31,8 @@ import javax.swing.Icon; import javax.swing.JLabel; import javax.swing.JPanel; +import com.google.common.collect.Maps; + import com.samskivert.swing.util.SwingUtil; import com.threerings.util.Name; @@ -213,7 +215,7 @@ public class TurnDisplay extends JPanel protected TurnGameObject _turnObj; /** A mapping of the labels currently associated with each player. */ - protected HashMap _labels = new HashMap(); + protected HashMap _labels = Maps.newHashMap(); /** The game-specified player icons. */ protected Icon[] _playerIcons; diff --git a/src/java/com/threerings/parlor/util/RobotPlayer.java b/src/java/com/threerings/parlor/util/RobotPlayer.java index 27312613..d0faec68 100644 --- a/src/java/com/threerings/parlor/util/RobotPlayer.java +++ b/src/java/com/threerings/parlor/util/RobotPlayer.java @@ -21,11 +21,12 @@ package com.threerings.parlor.util; -import java.util.ArrayList; import java.util.List; import java.awt.Component; +import com.google.common.collect.Lists; + import com.samskivert.util.CollectionUtil; import com.samskivert.util.Interval; import com.samskivert.util.RandomUtil; @@ -118,10 +119,10 @@ public class RobotPlayer extends Interval protected long _robotDelay = DEFAULT_ROBOT_DELAY; /** The list of available key press action commands. */ - protected List _press = new ArrayList(); + protected List _press = Lists.newArrayList(); /** The list of available key release action commands. */ - protected List _release = new ArrayList(); + protected List _release = Lists.newArrayList(); /** The key translator that describes available keys and commands. */ protected KeyTranslator _xlate; diff --git a/src/java/com/threerings/puzzle/client/PuzzleBoardView.java b/src/java/com/threerings/puzzle/client/PuzzleBoardView.java index d9df29e2..0cc042e1 100644 --- a/src/java/com/threerings/puzzle/client/PuzzleBoardView.java +++ b/src/java/com/threerings/puzzle/client/PuzzleBoardView.java @@ -21,7 +21,6 @@ package com.threerings.puzzle.client; -import java.util.ArrayList; import java.util.List; import java.awt.Color; @@ -31,6 +30,8 @@ import java.awt.Font; import java.awt.Graphics2D; import java.awt.Rectangle; +import com.google.common.collect.Lists; + import com.samskivert.util.StringUtil; import com.samskivert.swing.Label; @@ -375,10 +376,10 @@ public abstract class PuzzleBoardView extends VirtualMediaPanel protected Rectangle _bounds; /** The action animations on the board. */ - protected List _actionAnims = new ArrayList(); + protected List _actionAnims = Lists.newArrayList(); /** The action sprites on the board. */ - protected List _actionSprites = new ArrayList(); + protected List _actionSprites = Lists.newArrayList(); /** Prevents certain animations from overlapping others. */ protected AnimationArranger _avoidArranger; diff --git a/src/java/com/threerings/stage/client/SceneColorizer.java b/src/java/com/threerings/stage/client/SceneColorizer.java index 02a86ef7..c5d03fcb 100644 --- a/src/java/com/threerings/stage/client/SceneColorizer.java +++ b/src/java/com/threerings/stage/client/SceneColorizer.java @@ -21,10 +21,11 @@ package com.threerings.stage.client; -import java.util.HashMap; import java.util.Iterator; import java.util.Map; +import com.google.common.collect.Maps; + import com.threerings.media.image.ColorPository; import com.threerings.media.image.Colorization; import com.threerings.media.tile.TileSet; @@ -145,5 +146,5 @@ public class SceneColorizer implements TileSet.Colorizer protected StageScene _scene; /** Contains our colorization class information. */ - protected Map _cids = new HashMap(); + protected Map _cids = Maps.newHashMap(); } diff --git a/src/java/com/threerings/stage/data/StageScene.java b/src/java/com/threerings/stage/data/StageScene.java index 629da007..5b684dd0 100644 --- a/src/java/com/threerings/stage/data/StageScene.java +++ b/src/java/com/threerings/stage/data/StageScene.java @@ -24,6 +24,8 @@ package com.threerings.stage.data; import java.util.ArrayList; import java.util.Iterator; +import com.google.common.collect.Lists; + import com.threerings.crowd.data.PlaceConfig; import com.threerings.miso.data.ObjectInfo; @@ -223,5 +225,5 @@ public class StageScene extends SceneImpl protected SpotSceneImpl _sdelegate; /** A list of all interesting scene objects. */ - protected ArrayList _objects = new ArrayList(); + protected ArrayList _objects = Lists.newArrayList(); } diff --git a/src/java/com/threerings/stage/server/StageSceneManager.java b/src/java/com/threerings/stage/server/StageSceneManager.java index d5dbabcb..0f2868ef 100644 --- a/src/java/com/threerings/stage/server/StageSceneManager.java +++ b/src/java/com/threerings/stage/server/StageSceneManager.java @@ -29,6 +29,9 @@ import java.util.List; import java.awt.Point; import java.awt.Rectangle; +import com.google.common.collect.Lists; +import com.google.common.collect.Sets; + import com.samskivert.util.HashIntMap; import com.threerings.presents.data.ClientObject; @@ -819,14 +822,14 @@ public class StageSceneManager extends SpotSceneManager /** Rectangles describing the footprints (in tile coordinates) of all * of our scene objects. */ - protected ArrayList _footprints = new ArrayList(); + protected ArrayList _footprints = Lists.newArrayList(); /** Rectangles containing a "footprint" for the users that aren't in * any clusters. */ protected HashIntMap _loners = new HashIntMap(); /** Contains the (tile) coordinates of all of our portals. */ - protected HashSet _plocs = new HashSet(); + protected HashSet _plocs = Sets.newHashSet(); /** The dimensions of a cluster with the specified number of * occupants. */ diff --git a/src/java/com/threerings/stage/tools/editor/EditorScenePanel.java b/src/java/com/threerings/stage/tools/editor/EditorScenePanel.java index 5a6cecb5..eaae0ed2 100644 --- a/src/java/com/threerings/stage/tools/editor/EditorScenePanel.java +++ b/src/java/com/threerings/stage/tools/editor/EditorScenePanel.java @@ -1167,7 +1167,7 @@ public class EditorScenePanel extends StageScenePanel protected SceneObject _pscobj; /** A list of things that will do some extra painting for us. */ - protected ArrayList _extras = new ArrayList(); + protected ArrayList _extras = Lists.newArrayList(); /** The dialog providing portal edit functionality. */ protected PortalDialog _dialogPortal; diff --git a/src/java/com/threerings/stage/tools/editor/SceneInfoPanel.java b/src/java/com/threerings/stage/tools/editor/SceneInfoPanel.java index bce2fdcb..8aceac1a 100644 --- a/src/java/com/threerings/stage/tools/editor/SceneInfoPanel.java +++ b/src/java/com/threerings/stage/tools/editor/SceneInfoPanel.java @@ -38,6 +38,8 @@ import javax.swing.JTextField; import javax.swing.event.PopupMenuEvent; import javax.swing.event.PopupMenuListener; +import com.google.common.collect.Sets; + import com.samskivert.util.Collections; import com.samskivert.util.ComparableArrayList; @@ -45,6 +47,7 @@ import com.samskivert.swing.GroupLayout; import com.samskivert.swing.HGroupLayout; import com.threerings.media.image.ColorPository; +import com.threerings.media.image.ColorPository.ColorRecord; import com.threerings.media.tile.NoSuchTileSetException; import com.threerings.media.tile.RecolorableTileSet; import com.threerings.media.tile.TileManager; @@ -170,7 +173,7 @@ public class SceneInfoPanel extends JPanel { // add all possible colorization names to the list final TileManager tilemgr = _ctx.getTileManager(); - final HashSet set = new HashSet(); + final HashSet set = Sets.newHashSet(); StageMisoSceneModel msmodel = StageMisoSceneModel.getSceneModel( _scene.getSceneModel()); msmodel.visitObjects(new ObjectVisitor() { @@ -189,8 +192,8 @@ public class SceneInfoPanel extends JPanel return; } if (zations != null) { - for (int ii=0; ii < zations.length; ii++) { - set.add(zations[ii]); + for (String zation : zations) { + set.add(zation); } } } @@ -234,10 +237,10 @@ public class SceneInfoPanel extends JPanel ColorPository.ColorRecord[] colors = cpos.enumerateColors(cclass); ComparableArrayList list = new ComparableArrayList(); - for (int ii=0; ii < colors.length; ii++) { - list.insertSorted(colors[ii].name); - if (colors[ii].colorId == pick) { - choice = colors[ii].name; + for (ColorRecord color : colors) { + list.insertSorted(color.name); + if (color.colorId == pick) { + choice = color.name; } } @@ -268,9 +271,9 @@ public class SceneInfoPanel extends JPanel Object selected = _colorIds.getSelectedItem(); int pick = -1; - for (int ii=0; ii < colors.length; ii++) { - if (colors[ii].name.equals(selected)) { - pick = colors[ii].colorId; + for (ColorRecord color : colors) { + if (color.name.equals(selected)) { + pick = color.colorId; break; } } diff --git a/src/java/com/threerings/stage/tools/editor/TestTileLoader.java b/src/java/com/threerings/stage/tools/editor/TestTileLoader.java index 8c99e700..26bfc109 100644 --- a/src/java/com/threerings/stage/tools/editor/TestTileLoader.java +++ b/src/java/com/threerings/stage/tools/editor/TestTileLoader.java @@ -21,7 +21,6 @@ package com.threerings.stage.tools.editor; -import java.util.HashMap; import java.util.Iterator; import java.util.Map; @@ -34,6 +33,8 @@ import java.awt.image.BufferedImage; import javax.imageio.ImageIO; +import com.google.common.collect.Maps; + import com.samskivert.util.HashIntMap; import com.threerings.media.tile.ImageProvider; @@ -110,8 +111,8 @@ public class TestTileLoader implements TileSetIDBroker return f.isDirectory(); } }); - for (int ii=0; ii < subdirs.length; ii++) { - loadTestTilesFromDir(subdirs[ii], sets); + for (File subdir : subdirs) { + loadTestTilesFromDir(subdir, sets); } // now look for the xml file @@ -121,10 +122,10 @@ public class TestTileLoader implements TileSetIDBroker } }); - for (int ii=0; ii < xml.length; ii++) { - File xmlfile = new File(directory, xml[ii]); + for (String element : xml) { + File xmlfile = new File(directory, element); - Map tiles = new HashMap(); + Map tiles = Maps.newHashMap(); try { _parser.loadTileSets(xmlfile, tiles); } catch (IOException ioe) { @@ -179,7 +180,7 @@ public class TestTileLoader implements TileSetIDBroker protected int _fakeID = Short.MAX_VALUE; /** A mapping of pathname -> tileset id. */ - protected Map _idmap = new HashMap(); + protected Map _idmap = Maps.newHashMap(); /** Our xml parser. */ protected XMLTileSetParser _parser; diff --git a/src/java/com/threerings/stage/tools/editor/TileInfoPanel.java b/src/java/com/threerings/stage/tools/editor/TileInfoPanel.java index 3215b882..2f566add 100644 --- a/src/java/com/threerings/stage/tools/editor/TileInfoPanel.java +++ b/src/java/com/threerings/stage/tools/editor/TileInfoPanel.java @@ -56,6 +56,7 @@ import javax.swing.tree.DefaultTreeModel; import javax.swing.tree.TreePath; import javax.swing.tree.TreeSelectionModel; +import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.samskivert.util.HashIntMap; @@ -362,26 +363,24 @@ public class TileInfoPanel extends JSplitPane DefaultMutableTreeNode root = (DefaultMutableTreeNode) model.getRoot(); root.removeAllChildren(); - ArrayList expand = new ArrayList(); + ArrayList expand = Lists.newArrayList(); // add all the elements in the base layer DefaultMutableTreeNode base = new DefaultMutableTreeNode("Base Layer"); root.add(base); - addNodes(base, getSortedTileSets(EditorModel.BASE_LAYER), - "", 0, expand); + addNodes(base, getSortedTileSets(EditorModel.BASE_LAYER), "", 0, expand); // add all the elements in the object layer DefaultMutableTreeNode obj = new DefaultMutableTreeNode("Object Layer"); root.add(obj); - addNodes(obj, getSortedTileSets(EditorModel.OBJECT_LAYER), - "", 0, expand); + addNodes(obj, getSortedTileSets(EditorModel.OBJECT_LAYER), "", 0, expand); // notify the JTree that we've put some brand new branches on it. model.reload(); // expand our container categories - for (Iterator iter = expand.iterator(); iter.hasNext(); ) { - _tsettree.expandPath(iter.next()); + for (TreePath treePath : expand) { + _tsettree.expandPath(treePath); } // now select the previously selected item, or the first... diff --git a/src/java/com/threerings/stage/util/PlacementConstraints.java b/src/java/com/threerings/stage/util/PlacementConstraints.java index c28ae60b..81aa2c86 100644 --- a/src/java/com/threerings/stage/util/PlacementConstraints.java +++ b/src/java/com/threerings/stage/util/PlacementConstraints.java @@ -22,12 +22,12 @@ package com.threerings.stage.util; import java.util.HashMap; -import java.util.Iterator; import java.util.List; import java.awt.Rectangle; import com.google.common.collect.Lists; +import com.google.common.collect.Maps; import com.samskivert.util.ListUtil; @@ -225,20 +225,20 @@ public class PlacementConstraints } } - for (int i = 0; i < removed.length; i++) { - if (removed[i].tile.hasConstraint(ObjectTileSet.SURFACE) && - hasOnSurface(removed[i], added, removed)) { + for (ObjectData element : removed) { + if (element.tile.hasConstraint(ObjectTileSet.SURFACE) && + hasOnSurface(element, added, removed)) { return MessageBundle.qualify(STAGE_MESSAGE_BUNDLE, "m.has_on_surface"); } - int dir = getConstraintDirection(removed[i], ObjectTileSet.WALL); + int dir = getConstraintDirection(element, ObjectTileSet.WALL); if (dir != NONE) { - if (hasOnWall(removed[i], added, removed, dir)) { + if (hasOnWall(element, added, removed, dir)) { return MessageBundle.qualify(STAGE_MESSAGE_BUNDLE, "m.has_on_wall"); - } else if (hasAttached(removed[i], added, removed, dir)) { + } else if (hasAttached(element, added, removed, dir)) { return MessageBundle.qualify(STAGE_MESSAGE_BUNDLE, "m.has_attached"); } @@ -457,14 +457,14 @@ public class PlacementConstraints return false; } - for (int i = 0; i < constraints.length; i++) { - if (constraints[i].startsWith(prefix)) { + for (String constraint : constraints) { + if (constraint.startsWith(prefix)) { int fromidx = prefix.length(), - toidx = constraints[i].indexOf('_', fromidx); + toidx = constraint.indexOf('_', fromidx); dirheight.dir = DirectionUtil.fromShortString(toidx == -1 ? - constraints[i].substring(fromidx) : - constraints[i].substring(fromidx, toidx)); - dirheight.low = constraints[i].endsWith(ObjectTileSet.LOW); + constraint.substring(fromidx) : + constraint.substring(fromidx, toidx)); + dirheight.low = constraint.endsWith(ObjectTileSet.LOW); return true; } } @@ -503,17 +503,16 @@ public class PlacementConstraints { List list = Lists.newArrayList(); - for (Iterator it = _objectData.values().iterator(); it.hasNext(); ) { - ObjectData data = it.next(); + for (ObjectData data : _objectData.values()) { if (rect.intersects(data.bounds) && !ListUtil.contains(removed, data)) { list.add(data); } } - for (int i = 0; i < added.length; i++) { - if (rect.intersects(added[i].bounds)) { - list.add(added[i]); + for (ObjectData element : added) { + if (rect.intersects(element.bounds)) { + list.add(element); } } @@ -568,9 +567,8 @@ public class PlacementConstraints /** The Miso scene model. */ protected StageMisoSceneModel _mmodel; - /** For all objects in the scene, maps {@link ObjectInfo}s to - * {@link ObjectData}s. */ - protected HashMap _objectData = new HashMap(); + /** For all objects in the scene, maps {@link ObjectInfo}s to {@link ObjectData}s. */ + protected HashMap _objectData = Maps.newHashMap(); /** One rectangle we'll re-use for all constraints ops. */ protected static final Rectangle _constrainRect = new Rectangle(); diff --git a/src/java/com/threerings/stage/util/StageSceneUtil.java b/src/java/com/threerings/stage/util/StageSceneUtil.java index 8a66f63c..f3e28f35 100644 --- a/src/java/com/threerings/stage/util/StageSceneUtil.java +++ b/src/java/com/threerings/stage/util/StageSceneUtil.java @@ -21,13 +21,14 @@ package com.threerings.stage.util; -import java.util.ArrayList; import java.util.Comparator; import java.util.List; import java.awt.Point; import java.awt.Rectangle; +import com.google.common.collect.Lists; + import com.samskivert.util.SortableArrayList; import com.threerings.util.DirectionCodes; @@ -247,7 +248,7 @@ public class StageSceneUtil */ public static List getClusterLocs (Cluster cluster) { - List list = new ArrayList(); + List list = Lists.newArrayList(); // convert our tile coordinates into a cartesian coordinate system // with units equal to one fine coordinate in size diff --git a/src/java/com/threerings/stats/server/persist/StatRepository.java b/src/java/com/threerings/stats/server/persist/StatRepository.java index d13e2ad0..20eff8a7 100644 --- a/src/java/com/threerings/stats/server/persist/StatRepository.java +++ b/src/java/com/threerings/stats/server/persist/StatRepository.java @@ -11,6 +11,7 @@ import java.util.Set; import java.io.ByteArrayInputStream; import java.io.IOException; +import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.google.inject.Inject; import com.google.inject.Singleton; @@ -92,7 +93,7 @@ public class StatRepository extends DepotRepository */ public ArrayList loadStats (int playerId) { - ArrayList stats = new ArrayList(); + ArrayList stats = Lists.newArrayList(); Where where = new Where(StatRecord.PLAYER_ID, playerId); for (StatRecord record : findAll(StatRecord.class, where)) { Stat stat = decodeStat(record.statCode, record.statData, record.modCount); @@ -117,13 +118,13 @@ public class StatRepository extends DepotRepository */ public void writeModified (int playerId, Stat[] stats) { - for (int ii = 0; ii < stats.length; ii++) { + for (Stat stat : stats) { try { - if (stats[ii].getType().isPersistent() && stats[ii].isModified()) { - updateStat(playerId, stats[ii], true); + if (stat.getType().isPersistent() && stat.isModified()) { + updateStat(playerId, stat, true); } } catch (Exception e) { - log.warning("Error flushing modified stat", "stat", stats[ii], e); + log.warning("Error flushing modified stat", "stat", stat, e); } } } diff --git a/src/java/com/threerings/whirled/server/persist/SceneUpdateMarshaller.java b/src/java/com/threerings/whirled/server/persist/SceneUpdateMarshaller.java index ca56eac4..ff83969d 100644 --- a/src/java/com/threerings/whirled/server/persist/SceneUpdateMarshaller.java +++ b/src/java/com/threerings/whirled/server/persist/SceneUpdateMarshaller.java @@ -27,6 +27,8 @@ import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; +import com.google.common.collect.Maps; + import com.samskivert.io.PersistenceException; import com.samskivert.util.HashIntMap; @@ -166,7 +168,7 @@ public class SceneUpdateMarshaller protected HashIntMap> _typeToClass = new HashIntMap>(); /** The table mapping update classes to types. */ - protected HashMap,Integer> _classToType = new HashMap,Integer>(); + protected HashMap, Integer> _classToType = Maps.newHashMap(); /** A counter used in assigning update types to classes. */ protected int _nextType = 0; diff --git a/src/java/com/threerings/whirled/spot/server/SpotSceneManager.java b/src/java/com/threerings/whirled/spot/server/SpotSceneManager.java index 5fcc43e0..6e19a6b2 100644 --- a/src/java/com/threerings/whirled/spot/server/SpotSceneManager.java +++ b/src/java/com/threerings/whirled/spot/server/SpotSceneManager.java @@ -24,6 +24,8 @@ package com.threerings.whirled.spot.server; import java.util.HashMap; import java.util.Iterator; +import com.google.common.collect.Maps; + import com.samskivert.util.HashIntMap; import com.threerings.util.Name; @@ -591,5 +593,5 @@ public class SpotSceneManager extends SceneManager protected HashIntMap _clusters = new HashIntMap(); /** A mapping of entering bodies to portal ids. */ - protected HashMap _enterers = new HashMap(); + protected HashMap _enterers = Maps.newHashMap(); } diff --git a/src/java/com/threerings/whirled/tools/xml/SceneWriter.java b/src/java/com/threerings/whirled/tools/xml/SceneWriter.java index c2b0673d..268a5681 100644 --- a/src/java/com/threerings/whirled/tools/xml/SceneWriter.java +++ b/src/java/com/threerings/whirled/tools/xml/SceneWriter.java @@ -21,7 +21,6 @@ package com.threerings.whirled.tools.xml; -import java.util.HashMap; import java.util.Map; import java.io.File; @@ -31,6 +30,7 @@ import java.io.IOException; import org.xml.sax.SAXException; import org.xml.sax.helpers.AttributesImpl; +import com.google.common.collect.Maps; import com.megginson.sax.DataWriter; import com.threerings.tools.xml.NestableWriter; @@ -108,8 +108,7 @@ public class SceneWriter throws SAXException { // write out our auxiliary scene models - for (int ii = 0; ii < model.auxModels.length; ii++) { - AuxModel amodel = model.auxModels[ii]; + for (AuxModel amodel : model.auxModels) { NestableWriter awriter = _auxers.get(amodel.getClass()); if (awriter != null) { awriter.write(amodel, writer); @@ -120,5 +119,5 @@ public class SceneWriter } } - protected Map, NestableWriter> _auxers = new HashMap, NestableWriter>(); + protected Map, NestableWriter> _auxers = Maps.newHashMap(); } diff --git a/src/java/com/threerings/whirled/zone/client/ZoneDirector.java b/src/java/com/threerings/whirled/zone/client/ZoneDirector.java index 2121d48b..8c894fe1 100644 --- a/src/java/com/threerings/whirled/zone/client/ZoneDirector.java +++ b/src/java/com/threerings/whirled/zone/client/ZoneDirector.java @@ -23,6 +23,8 @@ package com.threerings.whirled.zone.client; import java.util.ArrayList; +import com.google.common.collect.Lists; + import com.samskivert.util.ResultListener; import com.threerings.presents.client.BasicDirector; @@ -289,7 +291,7 @@ public class ZoneDirector extends BasicDirector protected ZoneSummary _summary; /** Our zone observer list. */ - protected ArrayList _observers = new ArrayList(); + protected ArrayList _observers = Lists.newArrayList(); /** Our previous zone id. */ protected int _previousZoneId = -1;