From f12cf8a04e21c9bd3afe54e1a1f673295169ccd4 Mon Sep 17 00:00:00 2001 From: "ray.j.greenwell" Date: Tue, 21 Sep 2010 23:00:07 +0000 Subject: [PATCH] - Append chars when possible, and avoid any String concatination. - Made arrayStr static, soften the Exception thrown. git-svn-id: https://samskivert.googlecode.com/svn/trunk@2893 6335cc39-0255-0410-8fd6-9bcaacd3b74c --- src/main/java/com/samskivert/util/LogBuilder.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/samskivert/util/LogBuilder.java b/src/main/java/com/samskivert/util/LogBuilder.java index 19c6d60a..c3d6267c 100644 --- a/src/main/java/com/samskivert/util/LogBuilder.java +++ b/src/main/java/com/samskivert/util/LogBuilder.java @@ -63,12 +63,12 @@ public class LogBuilder _log.append('['); _hasArgs = true; } - _log.append(args[ii]).append("="); + _log.append(args[ii]).append('='); try { Object arg = args[ii + 1]; _log.append(((arg == null) || !arg.getClass().isArray()) ? arg : arrayStr(arg)); } catch (Throwable t) { - _log.append(""); + _log.append("'); } } } @@ -94,7 +94,7 @@ public class LogBuilder /** * Return the String representation of the specified Object, which must be an array. */ - protected String arrayStr (Object arg) + protected static String arrayStr (Object arg) { if (arg instanceof Object[]) { return Arrays.deepToString((Object[])arg); // go deep, baby @@ -123,7 +123,7 @@ public class LogBuilder } else if (arg instanceof boolean[]) { return Arrays.toString((boolean[])arg); } - throw new AssertionError("Not an array: " + arg); + throw new IllegalArgumentException("Not an array: " + arg); } protected boolean _hasArgs;