AfflictionNetworks/samskivert
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't do anything if there are no observers to notify.

Browse Source 
Shrink our working array if it's much larger than it needs to be.


git-svn-id: https://samskivert.googlecode.com/svn/trunk@1888 6335cc39-0255-0410-8fd6-9bcaacd3b74c
This commit is contained in:
ray
2006-08-21 21:31:44 +00:00
parent f2d299dc77
commit d0cfcca2fa
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/samskivert/util/ObserverList.java
+6 -3
View File
@@ -178,13 +178,17 @@ public class ObserverList<T> extends ArrayList<T>
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public void apply (ObserverOp<T> obop) public void apply (ObserverOp<T> obop)
{ {
int ocount = size();
if (ocount == 0) {
return;
}
if (_policy == SAFE_IN_ORDER_NOTIFY) { if (_policy == SAFE_IN_ORDER_NOTIFY) {
// if we have to notify our observers in order, we need to // if we have to notify our observers in order, we need to
// create a snapshot of the observer array at the time we // create a snapshot of the observer array at the time we
// start the notification to ensure that modifications to the // start the notification to ensure that modifications to the
// array during notification don't hose us // array during notification don't hose us
int ocount = size(); if (_snap == null || _snap.length < ocount ||
if (_snap == null || _snap.length < ocount) { _snap.length > (ocount << 3)) {
_snap = (T[])new Object[ocount]; _snap = (T[])new Object[ocount];
} }
Object[] obs = toArray(_snap); Object[] obs = toArray(_snap);
@@ -197,7 +201,6 @@ public class ObserverList<T> extends ArrayList<T>
Arrays.fill(_snap, null); Arrays.fill(_snap, null);
} else if (_policy == FAST_UNSAFE_NOTIFY) { } else if (_policy == FAST_UNSAFE_NOTIFY) {
int ocount = size();
for (int ii = ocount-1; ii >= 0; ii--) { for (int ii = ocount-1; ii >= 0; ii--) {
if (!checkedApply(obop, get(ii))) { if (!checkedApply(obop, get(ii))) {
remove(ii); remove(ii);