From 91e8240a48f6d49c4ab96e5b9e8543e1ad460912 Mon Sep 17 00:00:00 2001 From: samskivert Date: Wed, 8 Sep 2010 18:35:08 +0000 Subject: [PATCH] Fiddling with persistent properties in tests is dangerous. Let's be sure that our tests pass even when we haven't run them before. We were relying on sub.sub3 having been set and persisted from a previous test invocation. git-svn-id: https://samskivert.googlecode.com/svn/trunk@2848 6335cc39-0255-0410-8fd6-9bcaacd3b74c --- src/test/java/com/samskivert/util/ConfigTest.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/test/java/com/samskivert/util/ConfigTest.java b/src/test/java/com/samskivert/util/ConfigTest.java index 46abe883..0205f14b 100644 --- a/src/test/java/com/samskivert/util/ConfigTest.java +++ b/src/test/java/com/samskivert/util/ConfigTest.java @@ -61,11 +61,6 @@ public class ConfigTest pconfig.setValue("prop2", "three"); assertEquals("three", pconfig.getValue("prop2", "two")); - List list = CollectionUtil.addAll(new ArrayList(), pconfig.keys()); - Collections.sort(list); - assertEquals("(prop1, prop2, prop3, prop4, sub.sub1, sub.sub2, sub.sub3)", - StringUtil.toString(list)); - // fiddly with sub-properties pconfig.setValue("sub.sub3", "three"); Properties subprops = pconfig.getSubProperties("sub"); @@ -77,5 +72,11 @@ public class ConfigTest } Collections.sort(slist); assertEquals("(sub1, sub2, sub3)", StringUtil.toString(slist)); + + // check the whole shebang + List list = CollectionUtil.addAll(new ArrayList(), pconfig.keys()); + Collections.sort(list); + assertEquals("(prop1, prop2, prop3, prop4, sub.sub1, sub.sub2, sub.sub3)", + StringUtil.toString(list)); } }