From 590be465d75e095a5dd5b9eee9bcd55abf4f1181 Mon Sep 17 00:00:00 2001
From: "ray.j.greenwell" <ray.j.greenwell@6335cc39-0255-0410-8fd6-9bcaacd3b74c>
Date: Fri, 17 Sep 2010 20:53:00 +0000
Subject: [PATCH] Why are we silently ignoring the last argument if someone
 passes in an odd number?

Instead, let's log:
  message [name1=value1, name2=<toString failure: ArrayIndexOutOfBoundsException>]


git-svn-id: https://samskivert.googlecode.com/svn/trunk@2888 6335cc39-0255-0410-8fd6-9bcaacd3b74c
---
 src/main/java/com/samskivert/util/LogBuilder.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/com/samskivert/util/LogBuilder.java b/src/main/java/com/samskivert/util/LogBuilder.java
index 19c6d60a..5801a369 100644
--- a/src/main/java/com/samskivert/util/LogBuilder.java
+++ b/src/main/java/com/samskivert/util/LogBuilder.java
@@ -51,8 +51,8 @@ public class LogBuilder
      */
     public LogBuilder append (Object... args)
     {
-        if (args != null && args.length > 1) {
-            for (int ii = 0, nn = args.length - (args.length % 2); ii < nn; ii += 2) {
+        if (args != null) {
+            for (int ii = 0, nn = args.length; ii < nn; ii += 2) {
                 if (_hasArgs) {
                     _log.append(", ");
                 } else {
@@ -65,7 +65,7 @@ public class LogBuilder
                 }
                 _log.append(args[ii]).append("=");
                 try {
-                    Object arg = args[ii + 1];
+                    Object arg = args[ii + 1]; // this may cause ArrayIndexOutOfBoundsException
                     _log.append(((arg == null) || !arg.getClass().isArray()) ? arg : arrayStr(arg));
                 } catch (Throwable t) {
                     _log.append("<toString() failure: " + t + ">");