From 3efec4861bd26e20d9c10e329b874a971d0b4305 Mon Sep 17 00:00:00 2001 From: mdb Date: Wed, 2 Feb 2005 02:13:50 +0000 Subject: [PATCH] Only report when we actually do something. git-svn-id: https://samskivert.googlecode.com/svn/trunk@1584 6335cc39-0255-0410-8fd6-9bcaacd3b74c --- .../java/com/samskivert/jdbc/JDBCUtil.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/projects/samskivert/src/java/com/samskivert/jdbc/JDBCUtil.java b/projects/samskivert/src/java/com/samskivert/jdbc/JDBCUtil.java index 9310d9ff..4c0a2475 100644 --- a/projects/samskivert/src/java/com/samskivert/jdbc/JDBCUtil.java +++ b/projects/samskivert/src/java/com/samskivert/jdbc/JDBCUtil.java @@ -300,8 +300,8 @@ public class JDBCUtil throws SQLException { if (JDBCUtil.tableContainsColumn(conn, table, cname)) { - Log.info("Database table '" + table + "' already has column '" + - cname + "'."); +// Log.info("Database table '" + table + "' already has column '" + +// cname + "'."); return; } @@ -334,13 +334,13 @@ public class JDBCUtil PreparedStatement stmt = null; try { stmt = conn.prepareStatement(update); - stmt.executeUpdate(); + if (stmt.executeUpdate() == 1) { + Log.info("Database index '" + iname + "' removed from " + + "table '" + table + "'."); + } } finally { close(stmt); } - - Log.info("Database index '" + iname + "' removed from table '" + table + - "'."); } /** @@ -354,12 +354,12 @@ public class JDBCUtil PreparedStatement stmt = null; try { stmt = conn.prepareStatement(update); - stmt.executeUpdate(); + if (stmt.executeUpdate() == 1) { + Log.info("Database primary key removed from '" + table + "'."); + } } finally { close(stmt); } - - Log.info("Database primary key removed from table '" + table + "'."); } /** @@ -372,9 +372,9 @@ public class JDBCUtil throws SQLException { if (JDBCUtil.tableContainsIndex(conn, table, cname, iname)) { - Log.info("Database table '" + table + "' already has an index on " + - "column '" + cname + "'" + - (iname != null ? " named '" + iname + "'." : ".")); +// Log.info("Database table '" + table + "' already has an index " + +// "on column '" + cname + "'" + +// (iname != null ? " named '" + iname + "'." : ".")); return; }