diff --git a/src/java/com/samskivert/jdbc/DatabaseLiaison.java b/src/java/com/samskivert/jdbc/DatabaseLiaison.java index 0ff7c683..01cf2c48 100644 --- a/src/java/com/samskivert/jdbc/DatabaseLiaison.java +++ b/src/java/com/samskivert/jdbc/DatabaseLiaison.java @@ -57,14 +57,6 @@ public interface DatabaseLiaison */ public boolean isTransientException (SQLException sqe); - /** - * This method initializes the column value auto-generator described in {@link - * #lastInsertedId}. - */ - public void initializeGenerator ( - Connection conn, String table, String column, int first, int step) - throws SQLException; - /** * This method deletes the column value auto-generator described in {@link * #lastInsertedId}. diff --git a/src/java/com/samskivert/jdbc/MySQLLiaison.java b/src/java/com/samskivert/jdbc/MySQLLiaison.java index 55ae62ab..cea0d95c 100644 --- a/src/java/com/samskivert/jdbc/MySQLLiaison.java +++ b/src/java/com/samskivert/jdbc/MySQLLiaison.java @@ -51,14 +51,6 @@ public class MySQLLiaison extends BaseLiaison msg.indexOf("Broken pipe") != -1)); } - // from DatabaseLiaison - public void initializeGenerator ( - Connection conn, String table, String column, int first, int step) - throws SQLException - { - // AUTO_INCREMENT does not allow this kind of control - } - public void deleteGenerator (Connection conn, String tableName, String columnName) throws SQLException { diff --git a/src/java/com/samskivert/jdbc/depot/IdentityValueGenerator.java b/src/java/com/samskivert/jdbc/depot/IdentityValueGenerator.java index b53cbbc4..7b85b2c4 100644 --- a/src/java/com/samskivert/jdbc/depot/IdentityValueGenerator.java +++ b/src/java/com/samskivert/jdbc/depot/IdentityValueGenerator.java @@ -46,8 +46,7 @@ public class IdentityValueGenerator extends ValueGenerator public void init (Connection conn, DatabaseLiaison liaison) throws SQLException { - liaison.initializeGenerator( - conn, _dm.getTableName(), _fm.getColumnName(), _initialValue, _allocationSize); + // identity value generators are auto-created by the database } @Override // from ValueGenerator diff --git a/src/java/com/samskivert/jdbc/depot/ValueGenerator.java b/src/java/com/samskivert/jdbc/depot/ValueGenerator.java index 7d683040..0c9c2408 100644 --- a/src/java/com/samskivert/jdbc/depot/ValueGenerator.java +++ b/src/java/com/samskivert/jdbc/depot/ValueGenerator.java @@ -53,7 +53,7 @@ public abstract class ValueGenerator public abstract boolean isPostFactum (); /** - * Prepares the generator for operation. + * Ensures the generator is prepared for operation, creating it (only) if necessary. */ public abstract void init (Connection conn, DatabaseLiaison liaison) throws SQLException;