From 14ea28dd8aabb26dd91553787433b8c6f337de2d Mon Sep 17 00:00:00 2001
From: ray <ray@6335cc39-0255-0410-8fd6-9bcaacd3b74c>
Date: Fri, 22 Apr 2005 23:36:53 +0000
Subject: [PATCH] Changed some style/readability issues that bugged me.

git-svn-id: https://samskivert.googlecode.com/svn/trunk@1638 6335cc39-0255-0410-8fd6-9bcaacd3b74c
---
 .../servlet/util/ParameterUtil.java           | 24 ++++++++++---------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/projects/samskivert/src/java/com/samskivert/servlet/util/ParameterUtil.java b/projects/samskivert/src/java/com/samskivert/servlet/util/ParameterUtil.java
index c84c6e5b..583fc1b8 100644
--- a/projects/samskivert/src/java/com/samskivert/servlet/util/ParameterUtil.java
+++ b/projects/samskivert/src/java/com/samskivert/servlet/util/ParameterUtil.java
@@ -133,31 +133,33 @@ public class ParameterUtil
         HttpServletRequest req, String name, String invalidDataMessage)
         throws DataValidationException
     {
-        String[] values = req.getParameterValues(name);
         ArrayIntSet ints = new ArrayIntSet();
-        for (int ii = 0; values != null && ii < values.length; ii++) {
-            if (StringUtil.blank(values[ii])) {
-                continue;
+        String[] values = req.getParameterValues(name);
+        if (values != null) {
+            for (int ii = 0; ii < values.length; ii++) {
+                if (!StringUtil.blank(values[ii])) {
+                    ints.add(parseIntParameter(values[ii], invalidDataMessage));
+                }
             }
-            ints.add(parseIntParameter(values[ii], invalidDataMessage));
         }
         return ints;
     }
 
     /**
      * Fetches all the values from the request with the specified name and
-     * converts them HashSet. 
+     * converts them to a HashSet. 
      */
     public static HashSet getParameters (HttpServletRequest req, String name)
         throws DataValidationException
     {
-        String[] values = req.getParameterValues(name);
         HashSet set = new HashSet();
-        for (int ii = 0; values != null && ii < values.length; ii++) {
-            if (StringUtil.blank(values[ii])) {
-                continue;
+        String[] values = req.getParameterValues(name);
+        if (values != null) {
+            for (int ii = 0; ii < values.length; ii++) {
+                if (!StringUtil.blank(values[ii])) {
+                    set.add(values[ii]);
+                }
             }
-            set.add(values[ii]);
         }
         return set;
     }