Untabified. Made some string building use StringBuilder.

git-svn-id: https://samskivert.googlecode.com/svn/trunk@2734 6335cc39-0255-0410-8fd6-9bcaacd3b74c
This commit is contained in:
samskivert
2010-02-10 00:39:37 +00:00
parent b8b9a0d70a
commit 0aeab762aa
+18 -18
View File
@@ -221,13 +221,13 @@ public class Table<T>
public synchronized void insert (Connection conn, T obj) public synchronized void insert (Connection conn, T obj)
throws SQLException throws SQLException
{ {
String sql = "insert into " + name + StringBuilder sql = new StringBuilder(
" (" + listOfFields + ") values (?"; "insert into " + name + " (" + listOfFields + ") values (?");
for (int i = 1; i < nColumns; i++) { for (int i = 1; i < nColumns; i++) {
sql += ",?"; sql.append(",?");
} }
sql += ")"; sql.append(")");
PreparedStatement insertStmt = conn.prepareStatement(sql); PreparedStatement insertStmt = conn.prepareStatement(sql.toString());
bindUpdateVariables(insertStmt, obj, null); bindUpdateVariables(insertStmt, obj, null);
insertStmt.executeUpdate(); insertStmt.executeUpdate();
insertStmt.close(); insertStmt.close();
@@ -243,13 +243,13 @@ public class Table<T>
public synchronized void insert (Connection conn, T[] objects) public synchronized void insert (Connection conn, T[] objects)
throws SQLException throws SQLException
{ {
String sql = "insert into " + name + StringBuilder sql = new StringBuilder(
" (" + listOfFields + ") values (?"; "insert into " + name + " (" + listOfFields + ") values (?");
for (int i = 1; i < nColumns; i++) { for (int i = 1; i < nColumns; i++) {
sql += ",?"; sql.append(",?");
} }
sql += ")"; sql.append(")");
PreparedStatement insertStmt = conn.prepareStatement(sql); PreparedStatement insertStmt = conn.prepareStatement(sql.toString());
for (int i = 0; i < objects.length; i++) { for (int i = 0; i < objects.length; i++) {
bindUpdateVariables(insertStmt, objects[i], null); bindUpdateVariables(insertStmt, objects[i], null);
insertStmt.addBatch(); insertStmt.addBatch();
@@ -366,12 +366,12 @@ public class Table<T>
"No primary key for table " + name + "."); "No primary key for table " + name + ".");
} }
int nDeleted = 0; int nDeleted = 0;
String sql = "delete from " + name + StringBuilder sql = new StringBuilder(
" where " + primaryKeys[0] + " = ?"; "delete from " + name + " where " + primaryKeys[0] + " = ?");
for (int i = 1; i < primaryKeys.length; i++) { for (int i = 1; i < primaryKeys.length; i++) {
sql += " and " + primaryKeys[i] + " = ?"; sql.append(" and ").append(primaryKeys[i]).append(" = ?");
} }
PreparedStatement deleteStmt = conn.prepareStatement(sql); PreparedStatement deleteStmt = conn.prepareStatement(sql.toString());
for (int i = 0; i < primaryKeys.length; i++) { for (int i = 0; i < primaryKeys.length; i++) {
fields[primaryKeyIndices[i]].bindVariable(deleteStmt, obj,i+1); fields[primaryKeyIndices[i]].bindVariable(deleteStmt, obj,i+1);
} }
@@ -395,12 +395,12 @@ public class Table<T>
"No primary key for table " + name + "."); "No primary key for table " + name + ".");
} }
int nDeleted = 0; int nDeleted = 0;
String sql = "delete from " + name + StringBuilder sql = new StringBuilder(
" where " + primaryKeys[0] + " = ?"; "delete from " + name + " where " + primaryKeys[0] + " = ?");
for (int i = 1; i < primaryKeys.length; i++) { for (int i = 1; i < primaryKeys.length; i++) {
sql += " and " + primaryKeys[i] + " = ?"; sql.append(" and ").append(primaryKeys[i]).append(" = ?");
} }
PreparedStatement deleteStmt = conn.prepareStatement(sql); PreparedStatement deleteStmt = conn.prepareStatement(sql.toString());
for (int i = 0; i < objects.length; i++) { for (int i = 0; i < objects.length; i++) {
for (int j = 0; j < primaryKeys.length; j++) { for (int j = 0; j < primaryKeys.length; j++) {
fields[primaryKeyIndices[j]].bindVariable( fields[primaryKeyIndices[j]].bindVariable(