From 403bafce13fbc9917d4a547e06bcf60b57876c4c Mon Sep 17 00:00:00 2001 From: Michael Bayne Date: Tue, 11 Oct 2011 13:17:05 -0700 Subject: [PATCH] Ray recommends using <= when comparing to epsilon. This allows epsilon of 0 to work. --- src/main/java/pythagoras/d/Vectors.java | 4 ++-- src/main/java/pythagoras/f/Vectors.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/pythagoras/d/Vectors.java b/src/main/java/pythagoras/d/Vectors.java index 72cd9c7..0a3d262 100644 --- a/src/main/java/pythagoras/d/Vectors.java +++ b/src/main/java/pythagoras/d/Vectors.java @@ -66,7 +66,7 @@ public class Vectors * magnitude. */ public static boolean isEpsilonZero (double x, double y, double epsilon) { - return Math.abs(x) < epsilon && Math.abs(y) < epsilon; + return Math.abs(x) <= epsilon && Math.abs(y) <= epsilon; } /** @@ -82,7 +82,7 @@ public class Vectors * {@code epsilon}. */ public static boolean epsilonEquals (IVector v1, IVector v2, double epsilon) { - return Math.abs(v1.x() - v2.x()) < epsilon && Math.abs(v1.y() - v2.y()) < epsilon; + return Math.abs(v1.x() - v2.x()) <= epsilon && Math.abs(v1.y() - v2.y()) <= epsilon; } /** diff --git a/src/main/java/pythagoras/f/Vectors.java b/src/main/java/pythagoras/f/Vectors.java index 1cb2fbb..f0a12bc 100644 --- a/src/main/java/pythagoras/f/Vectors.java +++ b/src/main/java/pythagoras/f/Vectors.java @@ -66,7 +66,7 @@ public class Vectors * magnitude. */ public static boolean isEpsilonZero (float x, float y, float epsilon) { - return Math.abs(x) < epsilon && Math.abs(y) < epsilon; + return Math.abs(x) <= epsilon && Math.abs(y) <= epsilon; } /** @@ -82,7 +82,7 @@ public class Vectors * {@code epsilon}. */ public static boolean epsilonEquals (IVector v1, IVector v2, float epsilon) { - return Math.abs(v1.x() - v2.x()) < epsilon && Math.abs(v1.y() - v2.y()) < epsilon; + return Math.abs(v1.x() - v2.x()) <= epsilon && Math.abs(v1.y() - v2.y()) <= epsilon; } /**