From b3b2ca4926c68da3df6a403788e51f0a549c78a7 Mon Sep 17 00:00:00 2001 From: Michael Bayne Date: Wed, 5 Oct 2011 15:53:41 -0700 Subject: [PATCH] Make the Log holders package-only. They're an implementation detail, not an exported public API. It would be nice if Java allowed for package-plus-subpackage visibility. I'm tempted to just use a Log class per-package across the board, which would allow one to omit the import and use Log.log.info() which isn't half bad. It's certainly better than adding a static Logger field to every single class that uses logging, which is the "best practice" used by every other Java developer in the world. --- src/main/java/com/threerings/servlet/util/Log.java | 2 +- src/main/java/com/threerings/util/Log.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/threerings/servlet/util/Log.java b/src/main/java/com/threerings/servlet/util/Log.java index e708794..2a8f041 100644 --- a/src/main/java/com/threerings/servlet/util/Log.java +++ b/src/main/java/com/threerings/servlet/util/Log.java @@ -10,7 +10,7 @@ import com.samskivert.util.Logger; /** * Contains a reference to the log object used by this package. */ -public class Log +class Log { /** We dispatch our log messages through this logger. */ public static Logger log = Logger.getLogger("ooo-servlet-util"); diff --git a/src/main/java/com/threerings/util/Log.java b/src/main/java/com/threerings/util/Log.java index 83ea93c..c38d988 100644 --- a/src/main/java/com/threerings/util/Log.java +++ b/src/main/java/com/threerings/util/Log.java @@ -10,7 +10,7 @@ import com.samskivert.util.Logger; /** * Contains a reference to the log object used by this package. */ -public class Log +class Log { /** We dispatch our log messages through this logger. */ public static Logger log = Logger.getLogger("ooo-util");