From db91a42b05459ecca432f60b0f38733c0a8a51c9 Mon Sep 17 00:00:00 2001 From: Michael Bayne Date: Thu, 26 Oct 2006 23:09:43 +0000 Subject: [PATCH] More juicy fallthrough bug finding. git-svn-id: svn+ssh://src.earth.threerings.net/nenya/trunk@65 ed5b42cb-e716-0410-a449-f6a68f950b19 --- build.xml | 4 +++- src/java/com/threerings/miso/client/DirtyItemList.java | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/build.xml b/build.xml index 206e92ca..67f9bb81 100644 --- a/build.xml +++ b/build.xml @@ -96,7 +96,9 @@ - + + + diff --git a/src/java/com/threerings/miso/client/DirtyItemList.java b/src/java/com/threerings/miso/client/DirtyItemList.java index f58b01e0..2dedf117 100644 --- a/src/java/com/threerings/miso/client/DirtyItemList.java +++ b/src/java/com/threerings/miso/client/DirtyItemList.java @@ -484,8 +484,7 @@ public class DirtyItemList * Returns whether two dirty items have a partitioning object * between them on the given axis. */ - protected int comparePartitioned ( - int axis, DirtyItem da, DirtyItem db) + protected int comparePartitioned (int axis, DirtyItem da, DirtyItem db) { // prepare for the partitioning check SortableArrayList sitems; @@ -560,6 +559,7 @@ public class DirtyItemList dp.rx <= db.lx) { return (swapped) ? 1 : -1; } + break; case Y_AXIS: default: @@ -569,6 +569,7 @@ public class DirtyItemList dp.oy <= db.ry) { return (swapped) ? 1 : -1; } + break; } }