AfflictionNetworks/nenya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- fix floorDiv to handle negative divisors correctly

Browse Source 
git-svn-id: svn+ssh://src.earth.threerings.net/nenya/trunk@1065 ed5b42cb-e716-0410-a449-f6a68f950b19
This commit is contained in:
Mark Johnson
2010-11-13 00:50:16 +00:00
parent 85ca7f1c45
commit 4ce2d46976
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/threerings/media/util/MathUtil.java
+4 -4
View File
@@ -103,9 +103,7 @@ public class MathUtil
/** /**
* Computes the floored division <code>dividend/divisor</code> which * Computes the floored division <code>dividend/divisor</code> which
* is useful when dividing potentially negative numbers into bins. For * is useful when dividing potentially negative numbers into bins.
* positive numbers, it is the same as normal division, for negative
* numbers it returns <code>(dividend - divisor + 1) / divisor</code>.
* *
* <p> For example, the following numbers floorDiv 10 are: * <p> For example, the following numbers floorDiv 10 are:
* <pre> * <pre>
@@ -115,7 +113,9 @@ public class MathUtil
*/ */
public static int floorDiv (int dividend, int divisor) public static int floorDiv (int dividend, int divisor)
{ {
return ((dividend >= 0) ? dividend : (dividend - divisor + 1))/divisor; return ((dividend >= 0) == (divisor >= 0)) ?
dividend / divisor : (divisor >= 0 ?
(dividend - divisor + 1) / divisor : (dividend - divisor - 1) / divisor);
} }
/** /**