our no synchronization at the cost of possibly doing some trivial extra work.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6633 542714f4-19e9-0310-aa3c-eee0fc999fb1
processing messages, so let's put a (logging) NOOP handler in place when we
disconnect it from the PresentsSession.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6629 542714f4-19e9-0310-aa3c-eee0fc999fb1
it seems like we're still getting messages from old connections.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6627 542714f4-19e9-0310-aa3c-eee0fc999fb1
differently (specifically, we want to enable SO_REUSEADDR in Spiral Knights).
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6625 542714f4-19e9-0310-aa3c-eee0fc999fb1
lying around when the client reconnects. Let's try just clearing them out
again on resumption.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6619 542714f4-19e9-0310-aa3c-eee0fc999fb1
datagram PINGs. Let's make sure that the connection to which we're sending
the pong is the same one from which we received the ping. Ping, pong, ping,
pong.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6618 542714f4-19e9-0310-aa3c-eee0fc999fb1
us with lots of "Requested to clear unknown proxy" warnings in Spiral
Knights.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6606 542714f4-19e9-0310-aa3c-eee0fc999fb1
subclasses start nuking things, but once it is known that it will end.
It always bugged me in msoy that the session subclass has to do this (poorly). Seems patently
observer-ish. This fix has almost no runtime overhead and is backwards compatible. The name
isn't great, but I was leaving room for more methods in there should someone else find it
useful, such as sessionWillStart or even clientObject[Will|Did]Release.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6603 542714f4-19e9-0310-aa3c-eee0fc999fb1
constructors. Fixed ElementUpdatedEvent along the way.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6590 542714f4-19e9-0310-aa3c-eee0fc999fb1
it's totally wacky to have the ctor you shouldn't use, be public, and the one
you should, not.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6588 542714f4-19e9-0310-aa3c-eee0fc999fb1
because that will overwrite the hackery we do with _oldEntry. Oh hackery, how
we love you so.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6586 542714f4-19e9-0310-aa3c-eee0fc999fb1
breaks streaming. Everyone will have to regenerate their services. Sorry! If
only I hadn't hardcoded the insertion of the constructor in the first place,
this would have all been nicely behind an abstraction boundary. It will be once
the services are regenerated.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6584 542714f4-19e9-0310-aa3c-eee0fc999fb1
streamed property of the event. It turns out to be cleaner to just set it in
the places where we know that we want a specific transport anyway.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6581 542714f4-19e9-0310-aa3c-eee0fc999fb1
think that's probably just because we're used to it.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6577 542714f4-19e9-0310-aa3c-eee0fc999fb1
unserializing, or a weird alternative code path in the main constructor when
unserializing.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6576 542714f4-19e9-0310-aa3c-eee0fc999fb1
various base classes. This allows us to use final fields in some cases, which
I've done (though our naughty penchant for mutation forced me to roll back a
bunch of other spots where I would have liked to make fields final).
This is going to break a few things in dependents, because said dependents will
have zero argument constructors of their own which will need to be removed.
I'll be tracking those down and cleaning them up as build failures provide me
with infos.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6575 542714f4-19e9-0310-aa3c-eee0fc999fb1
constructor with zero/null values and then overwrite any fields initialized
with them immediately afterward" approach. If a Streamable has a zero-args
constructor, that is still used, so all the existing Streamable classes will
still function exactly as before. But new classes (or old classes undergoing
scrutiny) can opt to reduce their boilerplate as long as they know they cope
with the zero/null-valued constructor call.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6573 542714f4-19e9-0310-aa3c-eee0fc999fb1
Also, add some @Overrides that were missing on things that were overriding a base class method.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6570 542714f4-19e9-0310-aa3c-eee0fc999fb1
If we /didn't/ care at all about backwards compatibility, my preferred approach would have been to have the invoker for PeerManager injected in the constructor instead of as a field such that said constructor could be overridden and the invoker be injected with a different annotation.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6569 542714f4-19e9-0310-aa3c-eee0fc999fb1
RFC. I realize I need to add a lot of examples to the documentation.
The biggest win here is only needing to learn the ins and outs of
this one class, and using it everywhere for your listening/chaining needs.
Please, let me know what you think.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6568 542714f4-19e9-0310-aa3c-eee0fc999fb1
wearing the camouflage of being an empty method body.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6564 542714f4-19e9-0310-aa3c-eee0fc999fb1
how we're going to stream a class and then create the right streamer for it.
Using the ClassStreamer for an interface and then not doing any of the
ClassStreamer stuff means: don't use a ClassStreamer.
I went in here intending to find or create a dummy Streamable streamer that
all interfaces could share...
But, as it turns out, non-final arrays don't need a delegate streamer, so I can
just remove that and interface types will never create a Streamer.
(Interfaces can never be final.)
So: the problem just goes away and everything gets cleaner.
git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6563 542714f4-19e9-0310-aa3c-eee0fc999fb1
Michael Bayne