AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Thread.dumpStack() circumvents whatever logging is configured and writes

Browse Source 
directly to stderr. Logging an exception with the associated warning does the
right thing and logs the stack trace via the logging system.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5318 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Michael Bayne
2008-08-13 17:35:37 +00:00
parent b323bf6bf9
commit fcedbe90d7
16 changed files with 60 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/util/MessageBundle.java
+3 -6
View File
@@ -247,9 +247,7 @@ public class MessageBundle
}
if (reportMissing) {
log.warning("Missing translation message " +
"[bundle=" + _path + ", key=" + key + "].");
Thread.dumpStack();
log.warning("Missing translation message", "bundle", _path, "key", key, new Exception());
}
return null;
@@ -319,9 +317,8 @@ public class MessageBundle
}
} else {
log.warning("Missing translation message " +
"[bundle=" + _path + ", key=" + key + "].");
Thread.dumpStack();
log.warning("Missing translation message", "bundle", _path, "key", key,
new Exception());
}
}
src/java/com/threerings/util/TimeUtil.java
+10 -15
View File
@@ -47,10 +47,9 @@ public class TimeUtil
protected static final byte MAX_UNIT = DAY;
/**
* Get a translatable string specifying the magnitude of the specified
* duration. Results will be between "1 second" and "X hours", with
* all times rounded to the nearest unit. "0 units" will never be
* displayed, the minimum is 1.
* Get a translatable string specifying the magnitude of the specified duration. Results will
* be between "1 second" and "X hours", with all times rounded to the nearest unit. "0 units"
* will never be displayed, the minimum is 1.
*/
public static String getTimeOrderString (long duration, byte minUnit)
{
@@ -58,12 +57,11 @@ public class TimeUtil
}
/**
* Get a translatable string specifying the magnitude of the specified
* duration, with the units of time bounded between the minimum and
* maximum specified. "0 units" will never be returned, the minimum is 1.
* Get a translatable string specifying the magnitude of the specified duration, with the units
* of time bounded between the minimum and maximum specified. "0 units" will never be returned,
* the minimum is 1.
*/
public static String getTimeOrderString (
long duration, byte minUnit, byte maxUnit)
public static String getTimeOrderString (long duration, byte minUnit, byte maxUnit)
{
// enforce sanity
minUnit = (byte) Math.min(minUnit, maxUnit);
@@ -85,8 +83,7 @@ public class TimeUtil
}
/**
* Get a translatable string specifying the duration, down to the
* minimum granularity.
* Get a translatable string specifying the duration, down to the minimum granularity.
*/
public static String getTimeString (long duration, byte minUnit)
{
@@ -117,8 +114,7 @@ public class TimeUtil
}
/**
* Internal method to get the quantity for the specified unit.
* (Not very OO)
* Internal method to get the quantity for the specified unit. (Not very OO)
*/
protected static int getQuantityPerUnit (byte unit)
{
@@ -132,8 +128,7 @@ public class TimeUtil
}
/**
* Internal method to get the translation key for the specified unit.
* (Not very OO)
* Internal method to get the translation key for the specified unit. (Not very OO)
*/
protected static String getTransKey (byte unit)
{