AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Thread.dumpStack() circumvents whatever logging is configured and writes

Browse Source 
directly to stderr. Logging an exception with the associated warning does the
right thing and logs the stack trace via the logging system.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5318 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Michael Bayne
2008-08-13 17:35:37 +00:00
parent b323bf6bf9
commit fcedbe90d7
16 changed files with 60 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/presents/server/ClientManager.java
+5 -6
View File
@@ -306,8 +306,8 @@ public class ClientManager
{
ClientObject clobj = _objmap.get(username);
if (clobj == null) {
log.warning("Requested to release unmapped client object [username=" + username + "].");
Thread.dumpStack();
log.warning("Requested to release unmapped client object", "username", username,
new Exception());
return;
}
@@ -334,8 +334,8 @@ public class ClientManager
{
ClientObject clobj = _objmap.remove(oldname);
if (clobj == null) {
log.warning("Requested to rename unmapped client object [username=" + oldname + "].");
Thread.dumpStack();
log.warning("Requested to rename unmapped client object", "username", oldname,
new Exception());
return false;
}
_objmap.put(newname, clobj);
@@ -409,8 +409,7 @@ public class ClientManager
client.connectionFailed(fault);
} else if (!(conn instanceof AuthingConnection)) {
log.info("Unmapped connection failed? [conn=" + conn + ", fault=" + fault + "].");
Thread.dumpStack();
log.info("Unmapped connection failed?", "conn", conn, "fault", fault, new Exception());
}
}