From f80e1f07d8d90978843ac85448bccb5dd1876738 Mon Sep 17 00:00:00 2001
From: Charlie Groves <charlie@threerings.net>
Date: Tue, 30 Jun 2009 22:39:31 +0000
Subject: [PATCH] Break out command prefix checking

git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5842 542714f4-19e9-0310-aa3c-eee0fc999fb1
---
 .../crowd/chat/client/ChatDirector.java       | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/java/com/threerings/crowd/chat/client/ChatDirector.java b/src/java/com/threerings/crowd/chat/client/ChatDirector.java
index 9ddb9bc43..713a73610 100644
--- a/src/java/com/threerings/crowd/chat/client/ChatDirector.java
+++ b/src/java/com/threerings/crowd/chat/client/ChatDirector.java
@@ -957,24 +957,29 @@ public class ChatDirector extends BasicDirector
         HashMap<String, CommandHandler> matches = Maps.newHashMap();
         BodyObject user = (BodyObject)_ctx.getClient().getClientObject();
         for (Map.Entry<String, CommandHandler> entry : _handlers.entrySet()) {
-            String cmd = entry.getKey();
-            if (!cmd.startsWith(command)) {
+            if (!isCommandPrefix(command, entry.getKey(), entry.getValue(), user)) {
                 continue;
             }
-            CommandHandler handler = entry.getValue();
-            if (!handler.checkAccess(user)) {
-                continue;
-            }
-            if (cmd.equals(command)) {// If we hit an exact match, it wins
+            if (entry.getKey().equals(command)) {// If we hit an exact match, it wins
                 matches.clear();
-                matches.put(cmd, handler);
+                matches.put(entry.getKey(), entry.getValue());
                 return matches;
             }
-            matches.put(cmd, handler);
+            matches.put(entry.getKey(), entry.getValue());
         }
         return matches;
     }
 
+    /**
+     * Returns true if <code>enteredCommand</code> equals or is a prefix of
+     * <code>handlerCommand</code> and if the handler is available for <code>user</code>.
+     */
+    protected boolean isCommandPrefix (String enteredCommand, String handlerCommand,
+        CommandHandler handler, BodyObject user)
+    {
+        return handlerCommand.startsWith(enteredCommand) && handler.checkAccess(user);
+    }
+
     /**
      * Adds a chatter to our list of recent chatters.
      */