AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Using finalizers like this is a bad idea. I did this years ago.

Browse Source 
At least call super() in a finally block, but I'll see if this can
be cleaned.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6039 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Ray Greenwell
2010-02-17 02:38:11 +00:00
parent 83f71c606e
commit cbaa8e480e
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/presents/data/InvocationMarshaller.java
+6 -3
View File
@@ -120,10 +120,13 @@ public class InvocationMarshaller
protected void finalize () protected void finalize ()
throws Throwable throws Throwable
{ {
if (_invId != null && getClass() != ListenerMarshaller.class) { try {
log.warning("Invocation listener never responded to: " + _invId); if (_invId != null && getClass() != ListenerMarshaller.class) {
log.warning("Invocation listener never responded to: " + _invId);
}
} finally {
super.finalize();
} }
super.finalize();
} }
/** On the server, the id of the invocation method. */ /** On the server, the id of the invocation method. */