AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure to catch any error while processing our events, not just when

Browse Source 
actually dispatching the event to subscribers. We can't trust anyone.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@3308 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Michael Bayne
2005-01-24 07:59:31 +00:00
parent 05d72fb406
commit be93e5eb12
1 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/presents/server/PresentsDObjectMgr.java
+17 -16
View File
@@ -202,25 +202,26 @@ public class PresentsDObjectMgr
start = _timer.highResCounter(); start = _timer.highResCounter();
} }
// if this is a runnable, it's just an executable unit that try {
// should be invoked if (unit instanceof Runnable) {
if (unit instanceof Runnable) { // if this is a runnable, it's just an executable unit
try { // that should be invoked
((Runnable)unit).run(); ((Runnable)unit).run();
} catch (Exception e) {
Log.warning("Execution unit failed [unit=" + unit + "]."); } else if (unit instanceof CompoundEvent) {
Log.logStackTrace(e); processCompoundEvent((CompoundEvent)unit);
} catch (OutOfMemoryError oome) {
handleFatalError(unit, oome); } else {
} catch (StackOverflowError soe) { processEvent((DEvent)unit);
handleFatalError(unit, soe);
} }
} else if (unit instanceof CompoundEvent) { } catch (Exception e) {
processCompoundEvent((CompoundEvent)unit); Log.warning("Execution unit failed [unit=" + unit + "].");
Log.logStackTrace(e);
} else { } catch (OutOfMemoryError oome) {
processEvent((DEvent)unit); handleFatalError(unit, oome);
} catch (StackOverflowError soe) {
handleFatalError(unit, soe);
} }
if (start != 0L) { if (start != 0L) {