AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Take advantage of our new "one constructor to rule them all" capabilities in

Browse Source 
various base classes. This allows us to use final fields in some cases, which
I've done (though our naughty penchant for mutation forced me to roll back a
bunch of other spots where I would have liked to make fields final).

This is going to break a few things in dependents, because said dependents will
have zero argument constructors of their own which will need to be removed.
I'll be tracking those down and cleaning them up as build failures provide me
with infos.

git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@6575 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Michael Bayne
2011-04-01 22:06:42 +00:00
parent 61de392df9
commit b986464ee7
39 changed files with 127 additions and 511 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/threerings/presents/dobj/MessageEvent.java
+10 -36
View File
@@ -26,10 +26,9 @@ import com.samskivert.util.StringUtil;
import com.threerings.presents.net.Transport;
/**
* A message event is used to dispatch a message to all subscribers of a
* distributed object without actually changing any of the fields of the
* object. A message has a name, by which different subscribers of the
* same object can distinguish their different messages, and an array of
* A message event is used to dispatch a message to all subscribers of a distributed object without
* actually changing any of the fields of the object. A message has a name, by which different
* subscribers of the same object can distinguish their different messages, and an array of
* arguments by which any contents of the message can be delivered.
*
* @see DObjectManager#postEvent
@@ -37,29 +36,13 @@ import com.threerings.presents.net.Transport;
public class MessageEvent extends NamedEvent
{
/**
* Constructs a new message event on the specified target object with
* the supplied name and arguments.
* Constructs a new message event on the specified target object with the supplied name and
* arguments.
*
* @param targetOid the object id of the object whose attribute has
* changed.
* @param targetOid the object id of the object whose attribute has changed.
* @param name the name of the message event.
* @param args the arguments for this message. This array should
* contain only values of valid distributed object types.
*/
public MessageEvent (int targetOid, String name, Object[] args)
{
this(targetOid, name, args, Transport.DEFAULT);
}
/**
* Constructs a new message event on the specified target object with
* the supplied name and arguments.
*
* @param targetOid the object id of the object whose attribute has
* changed.
* @param name the name of the message event.
* @param args the arguments for this message. This array should
* contain only values of valid distributed object types.
* @param args the arguments for this message. This array should contain only values of valid
* distributed object types.
* @param transport a hint as to the type of transport desired for the event.
*/
public MessageEvent (int targetOid, String name, Object[] args, Transport transport)
@@ -68,14 +51,6 @@ public class MessageEvent extends NamedEvent
_args = args;
}
/**
* Constructs a blank instance of this event in preparation for
* unserialization from the network.
*/
public MessageEvent ()
{
}
/**
* Returns the arguments to this message.
*/
@@ -85,9 +60,8 @@ public class MessageEvent extends NamedEvent
}
/**
* Replaces the arguments associated with this message event.
* <em>Note:</em> this should only be called on events that have not
* yet been dispatched into the distributed object system.
* Replaces the arguments associated with this message event. <em>Note:</em> this should only
* be called on events that have not yet been dispatched into the distributed object system.
*/
public void setArgs (Object[] args)
{