Estimate memory usage in bytes rather than pixel area, assuming an int per

pixel for now.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@2034 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/media/image/ImageManager.java

@@ -1,5 +1,5 @@
 //
-// $Id: ImageManager.java,v 1.30 2002/12/07 01:10:25 shaper Exp $
+// $Id: ImageManager.java,v 1.31 2002/12/07 02:04:32 shaper Exp $
 
 package com.threerings.media;
 
@@ -155,9 +155,10 @@ public class ImageManager
     protected void reportCachePerformance ()
     {
         if (!_cacheStatThrottle.throttleOp()) {
-            int size = getCachedImageSize() / 1024;
+            long size = ImageUtil.getEstimatedMemoryUsage(
+                _imgs.values().iterator());
             int[] eff = _imgs.getTrackedEffectiveness();
-            Log.debug("ImageManager LRU [area=" + size + "k pixels" +
+            Log.debug("ImageManager LRU [mem=" + (size / 1024) + "k" +
                       ", size=" + _imgs.size() +  ", hits=" + eff[0] +
                       ", misses=" + eff[1] + "].");
         }
@@ -264,21 +265,6 @@ public class ImageManager
         return dest;
     }
 
-    /**
-     * Returns the estimated size of the cached images as the total area
-     * in pixels occupied by all images.
-     */
-    protected int getCachedImageSize ()
-    {
-        Iterator iter = _imgs.values().iterator();
-        int size = 0;
-        while (iter.hasNext()) {
-            Image image = (Image)iter.next();
-            size += (image.getWidth(null) * image.getHeight(null));
-        }
-        return size;
-    }
-
     /** A reference to the resource manager via which we load image data
      * by default. */
     protected ResourceManager _rmgr;

src/java/com/threerings/media/image/ImageUtil.java

@@ -1,5 +1,5 @@
 //
-// $Id: ImageUtil.java,v 1.18 2002/11/15 09:29:40 shaper Exp $
+// $Id: ImageUtil.java,v 1.19 2002/12/07 02:04:32 shaper Exp $
 
 package com.threerings.media.util;
 
@@ -23,6 +23,7 @@ import java.awt.image.Raster;
 import java.awt.image.WritableRaster;
 
 import java.util.Arrays;
+import java.util.Iterator;
 
 import com.samskivert.util.StringUtil;
 
@@ -527,6 +528,33 @@ public class ImageUtil
         tbounds.height = lastrow - firstrow + 1;
     }
 
+    /**
+     * Returns the estimated memory usage in bytes for the specified
+     * image.
+     */
+    public static long getEstimatedMemoryUsage (Image image)
+    {
+        int area = image.getWidth(null) * image.getHeight(null);
+        // TODO: we assume an int per pixel for now, but should really
+        // study the sample model if it's a buffered image to do more
+        // intelligent estimation.
+        return (area * 4);
+    }
+
+    /**
+     * Returns the estimated memory usage in bytes for all images in the
+     * supplied iterator.
+     */
+    public static long getEstimatedMemoryUsage (Iterator iter)
+    {
+        long size = 0;
+        while (iter.hasNext()) {
+            Image image = (Image)iter.next();
+            size += getEstimatedMemoryUsage(image);
+        }
+        return size;
+    }
+
     /**
      * Obtains the default graphics configuration for this VM.
      */