From 991b68638e0e91129664a7bea4eda2020dc8ad97 Mon Sep 17 00:00:00 2001
From: Michael Bayne <mdb@threerings.net>
Date: Thu, 24 Jul 2003 23:50:32 +0000
Subject: [PATCH] Yarrrrrrrrrrrrrrrrrrrrrrrrrrrgh!

git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@2725 542714f4-19e9-0310-aa3c-eee0fc999fb1
---
 bin/matchclasses | 45 +++++++++++++++++++++++----------------------
 1 file changed, 23 insertions(+), 22 deletions(-)

diff --git a/bin/matchclasses b/bin/matchclasses
index 709c99b53..1353766cf 100755
--- a/bin/matchclasses
+++ b/bin/matchclasses
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -w
 #
-# $Id: matchclasses,v 1.6 2003/07/24 23:40:16 mdb Exp $
+# $Id: matchclasses,v 1.7 2003/07/24 23:50:32 mdb Exp $
 #
 # A script which inspects a hierarchy of classes and generates lists of
 # classes that match specified criterion. The criterion are that a class
@@ -89,7 +89,7 @@ while (@gclasses) {
     my @cargs = splice(@gclasses, 0, min($ccount, 100));
     my $carg = "'" . join("' '", @cargs) . "'";
 
-    # print "javap -classpath $classpath $carg\n";
+    print "javap -classpath $classpath $carg\n";
 
     if (!open(JAVAP, "javap -classpath $classpath $carg|")) {
         warn "Can't inspect $carg: $!\n";
@@ -98,10 +98,10 @@ while (@gclasses) {
 
     # look for a line that identifies a class or interface
     while (<JAVAP>) {
-        next unless (/class/ || /interface/);
-
         chomp;
         my $goods = $_;
+        my $class;
+        next unless ($class = match_class($goods));
 
         # strip off the close brace
         $goods =~ s:\s*{\s*$::g;
@@ -113,6 +113,12 @@ while (@gclasses) {
             @ifaces = split(/,/, $idefs);
         }
 
+        if (@ifaces) {
+            $itable{$class} = \@ifaces;
+            print STDERR "-> $class I[" . join(":", @ifaces) . "]\n"
+                if ($debug);
+        }
+
         # now the parent class or parent interfaces are at the end
         my @parents;
         if ($goods =~ s: extends (.*)$::g) {
@@ -120,24 +126,6 @@ while (@gclasses) {
             @parents = split(/,/, $pdefs);
         }
 
-        # last is the class name
-        my $class;
-        if ($goods =~ s:(class|interface) ([A-Za-z0-9.\$]+)::g) {
-            $class = clean_class($2);
-            $class =~ s: ::g;
-        }
-
-        if (!defined $class) {
-            warn "Hrm, failed to parse '$_'.\n";
-            next;
-        }
-
-        if (@ifaces) {
-            $itable{$class} = \@ifaces;
-            print STDERR "-> $class I[" . join(":", @ifaces) . "]\n"
-                if ($debug);
-        }
-
         if (@parents) {
             $ptable{$class} = \@parents;
             print STDERR "-> $class E[" . join(":", @parents) . "]\n"
@@ -183,6 +171,19 @@ sub min {
     return ($a < $b) ? $a : $b;
 }
 
+# Matches a class declaration on the supplied line
+sub match_class {
+    my ($line) = @_;
+    # print "Matching $line\n";
+    if ($line !~ m:[a-z ]*(class|interface) ([A-Za-z0-9.\$]+):) {
+        return undef;
+    }
+    # print "Matched $2\n";
+    my $class = clean_class($2);
+    $class =~ s: ::g;
+    return $class;
+}
+
 # Cleans up class n ames as reported by javap
 sub clean_class {
     my ($class) = @_;