AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Just use a volatile variable and do away with the synchronization, at

Browse Source 
Mr. Greenwell's suggestion.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@3416 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Michael Bayne
2005-03-18 19:26:11 +00:00
parent 9682983526
commit 9434b6e9bc
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/presents/server/net/ConnectionManager.java
+3 -6
View File
@@ -119,7 +119,7 @@ public class ConnectionManager extends LoopingThread
* action may be specified and it may be cleared by calling this * action may be specified and it may be cleared by calling this
* method with null. * method with null.
*/ */
public synchronized void setShutdownAction (Runnable onExit) public void setShutdownAction (Runnable onExit)
{ {
_onExit = onExit; _onExit = onExit;
} }
@@ -546,10 +546,7 @@ public class ConnectionManager extends LoopingThread
// documentation inherited // documentation inherited
protected void didShutdown () protected void didShutdown ()
{ {
Runnable onExit = null; Runnable onExit = _onExit;
synchronized (this) {
onExit = _onExit;
}
if (onExit != null) { if (onExit != null) {
Log.info("Connection Manager thread exited (running onExit)."); Log.info("Connection Manager thread exited (running onExit).");
onExit.run(); onExit.run();
@@ -776,7 +773,7 @@ public class ConnectionManager extends LoopingThread
protected ConMgrStats _stats; protected ConMgrStats _stats;
/** A runnable to execute when the connection manager thread exits. */ /** A runnable to execute when the connection manager thread exits. */
protected Runnable _onExit; protected volatile Runnable _onExit;
/** Used to create an overflow queue on the first partial write. */ /** Used to create an overflow queue on the first partial write. */
protected PartialWriteHandler _oflowHandler = new PartialWriteHandler() { protected PartialWriteHandler _oflowHandler = new PartialWriteHandler() {