Fixed some unused variables, unused imports, type variable hiding, tricky

generic array type handling and other niggling bits.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5267 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/presents/client/BlockingCommunicator.java

@@ -827,7 +827,7 @@ public class BlockingCommunicator extends Communicator
                     return false; // cancelled
 
                 } else if (resp > 0) {
-                    DownstreamMessage msg = receiveDatagram();
+                    receiveDatagram();
                     return true;
                 }
             }

src/java/com/threerings/presents/client/ClientDObjectMgr.java

@@ -439,7 +439,7 @@ public class ClientDObjectMgr
         for (Iterator<IntMap.IntEntry<FlushRecord>> iter = _flushes.intEntrySet().iterator();
              iter.hasNext(); ) {
             IntMap.IntEntry<FlushRecord> entry = iter.next();
-            int oid = entry.getIntKey();
+//             int oid = entry.getIntKey();
             FlushRecord rec = entry.getValue();
             if (rec.expire <= now) {
                 iter.remove();

src/java/com/threerings/presents/client/InvocationDirector.java

@@ -154,7 +154,7 @@ public class InvocationDirector
                 log.warning("Receiver unregistered for which we have no id to code mapping " +
                             "[code=" + receiverCode + "].");
             } else {
-                Object decoder = _receivers.remove(rreg.receiverId);
+//                 Object decoder = _receivers.remove(rreg.receiverId);
 //                 Log.info("Cleared receiver " + StringUtil.shortClassName(decoder) +
 //                          " " + rreg + ".");
             }

src/java/com/threerings/presents/dobj/DynamicListener.java

@@ -120,7 +120,6 @@ public class DynamicListener
      */
     protected Method resolveMethod (String name, Object[] arguments)
     {
-        Class clazz = _target.getClass();
         Class[] ptypes = new Class[arguments.length];
         for (int ii = 0; ii < arguments.length; ii++) {
             ptypes[ii] = arguments[ii] == null ?

src/java/com/threerings/presents/server/PresentsClient.java

@@ -36,7 +36,6 @@ import com.samskivert.util.Throttle;
 import com.threerings.util.Name;
 
 import com.threerings.presents.data.ClientObject;
-import com.threerings.presents.data.InvocationMarshaller;
 
 import com.threerings.presents.dobj.DEvent;
 import com.threerings.presents.dobj.DObject;

src/java/com/threerings/presents/server/ShutdownManager.java

@@ -21,7 +21,6 @@
 
 package com.threerings.presents.server;
 
-
 import com.google.inject.Inject;
 import com.google.inject.Singleton;
 

src/java/com/threerings/presents/tools/ActionScriptSource.java

@@ -737,7 +737,7 @@ public class ActionScriptSource
                         line = slurpUntil(bin, line, ";", false);
                     }
 
-                    String fieldName = m.group(1);
+//                     String fieldName = m.group(1);
 
                     // TODO: update the comment?
                     accum.setLength(0);

src/java/com/threerings/presents/tools/GenStreamableTask.java

@@ -29,7 +29,6 @@ import java.lang.reflect.Modifier;
 
 import java.util.ArrayList;
 
-import org.apache.tools.ant.BuildException;
 import org.apache.tools.ant.DirectoryScanner;
 import org.apache.tools.ant.Task;
 import org.apache.tools.ant.types.FileSet;