Type the marshaller and associated registry methods so that we don't have to
downcast every time we register an invocation service provider. git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5201 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
@@ -29,25 +29,23 @@ import com.threerings.presents.data.InvocationMarshaller;
|
||||
import static com.threerings.presents.Log.log;
|
||||
|
||||
/**
|
||||
* Provides the base class via which invocation service requests are
|
||||
* dispatched.
|
||||
* Provides the base class via which invocation service requests are dispatched.
|
||||
*/
|
||||
public abstract class InvocationDispatcher
|
||||
public abstract class InvocationDispatcher<T extends InvocationMarshaller>
|
||||
{
|
||||
/** The invocation provider for whom we're dispatching. */
|
||||
public InvocationProvider provider;
|
||||
|
||||
/**
|
||||
* Creates an instance of the appropriate {@link InvocationMarshaller}
|
||||
* derived class for use with this dispatcher.
|
||||
* Creates an instance of the appropriate {@link InvocationMarshaller} derived class for use
|
||||
* with this dispatcher.
|
||||
*/
|
||||
public abstract InvocationMarshaller createMarshaller ();
|
||||
public abstract T createMarshaller ();
|
||||
|
||||
/**
|
||||
* Dispatches the specified method to our provider.
|
||||
*/
|
||||
public void dispatchRequest (
|
||||
ClientObject source, int methodId, Object[] args)
|
||||
public void dispatchRequest (ClientObject source, int methodId, Object[] args)
|
||||
throws InvocationException
|
||||
{
|
||||
log.warning("Requested to dispatch unknown method " +
|
||||
|
||||
@@ -102,7 +102,7 @@ public class InvocationManager
|
||||
*
|
||||
* @param dispatcher the dispatcher to be registered.
|
||||
*/
|
||||
public InvocationMarshaller registerDispatcher (InvocationDispatcher dispatcher)
|
||||
public <T extends InvocationMarshaller> T registerDispatcher (InvocationDispatcher<T> dispatcher)
|
||||
{
|
||||
return registerDispatcher(dispatcher, null);
|
||||
}
|
||||
@@ -110,8 +110,8 @@ public class InvocationManager
|
||||
/**
|
||||
* @Deprecated use {@link #registerDispatcher(InvocationDispatcher)}.
|
||||
*/
|
||||
public InvocationMarshaller registerDispatcher (
|
||||
InvocationDispatcher dispatcher, boolean bootstrap)
|
||||
public <T extends InvocationMarshaller> T registerDispatcher (
|
||||
InvocationDispatcher<T> dispatcher, boolean bootstrap)
|
||||
{
|
||||
return registerDispatcher(dispatcher, null);
|
||||
}
|
||||
@@ -126,13 +126,14 @@ public class InvocationManager
|
||||
* groups. You must collect shared dispatchers into as fine grained a set of groups as
|
||||
* necessary and have different types of clients specify the list of groups they need.
|
||||
*/
|
||||
public InvocationMarshaller registerDispatcher (InvocationDispatcher dispatcher, String group)
|
||||
public <T extends InvocationMarshaller> T registerDispatcher (
|
||||
InvocationDispatcher<T> dispatcher, String group)
|
||||
{
|
||||
// get the next invocation code
|
||||
int invCode = nextInvCode();
|
||||
|
||||
// create the marshaller and initialize it
|
||||
InvocationMarshaller marsh = dispatcher.createMarshaller();
|
||||
T marsh = dispatcher.createMarshaller();
|
||||
marsh.init(_invoid, invCode);
|
||||
|
||||
// register the dispatcher
|
||||
|
||||
@@ -29,7 +29,7 @@ import com.threerings.presents.data.TimeBaseMarshaller;
|
||||
/**
|
||||
* Dispatches requests to the {@link TimeBaseProvider}.
|
||||
*/
|
||||
public class TimeBaseDispatcher extends InvocationDispatcher
|
||||
public class TimeBaseDispatcher extends InvocationDispatcher<TimeBaseMarshaller>
|
||||
{
|
||||
/**
|
||||
* Creates a dispatcher that may be registered to dispatch invocation
|
||||
@@ -41,7 +41,7 @@ public class TimeBaseDispatcher extends InvocationDispatcher
|
||||
}
|
||||
|
||||
@Override // documentation inherited
|
||||
public InvocationMarshaller createMarshaller ()
|
||||
public TimeBaseMarshaller createMarshaller ()
|
||||
{
|
||||
return new TimeBaseMarshaller();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user