Javadoc warnings cleanups.

Note: this involves generated code from a samskivert patch I only just sent to mdb,
but he's in a meeting, so that won't show up for a little.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5369 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/presents/server/ClientManager.java

@@ -64,7 +64,7 @@ public class ClientManager
                ReportManager.Reporter, ShutdownManager.Shutdowner
 {
     /**
-     * Used by {@link #applyToClient}.
+     * Used by {@link ClientManager#applyToClient}.
      */
     public static interface ClientOp
     {
@@ -519,7 +519,7 @@ public class ClientManager
         }
     }
 
-    /** Used by {@link #applyToClient}. */
+    /** Used by {@link ClientManager#applyToClient}. */
     protected class ClientOpResolver
         implements ClientResolutionListener
     {

src/java/com/threerings/presents/server/InvocationException.java

@@ -46,7 +46,7 @@ public class InvocationException extends Exception
     }
 
     /**
-     * A version of {@link #requireAccess} that takes no context.
+     * A version of {@link #requireAccess(ClientObject,Permission,Object)} that takes no context.
      */
     public static void requireAccess (ClientObject clobj, Permission perm)
         throws InvocationException
@@ -55,8 +55,7 @@ public class InvocationException extends Exception
     }
 
     /**
-     * Constructs an invocation exception with the supplied cause code
-     * string.
+     * Constructs an invocation exception with the supplied cause code string.
      */
     public InvocationException (String cause)
     {
@@ -66,8 +65,7 @@ public class InvocationException extends Exception
     /**
      * Constructs an invocation exception with the supplied cause code
      * string and qualifying message bundle. The error code will be
-     * qualified with the message bundle (see {@link
-     * MessageBundle#qualify}).
+     * qualified with the message bundle (see {@link MessageBundle#qualify}).
      */
     public InvocationException (String bundle, String code)
     {

src/java/com/threerings/presents/server/PresentsClient.java

@@ -82,7 +82,7 @@ import static com.threerings.presents.Log.log;
 public class PresentsClient
     implements MessageHandler, ClientResolutionListener
 {
-    /** Used by {@link #setUsername} to report success or failure. */
+    /** Used by {@link PresentsClient#setUsername} to report success or failure. */
     public static interface UserChangeListener
     {
         /** Called when the new client object has been resolved and the new client object reported

src/java/com/threerings/presents/server/ReportManager.java

@@ -38,7 +38,10 @@ import static com.threerings.presents.Log.log;
 @Singleton
 public class ReportManager
 {
-    /** Used to generate "state of the server" reports. See {@link #registerReporter}. */
+    /**
+     * Used to generate "state of the server" reports.
+     * See {@link ReportManager#registerReporter}.
+     * */
     public static interface Reporter
     {
         /**
@@ -155,7 +158,7 @@ public class ReportManager
     /** The time at which the server was started. */
     protected long _serverStartTime = System.currentTimeMillis();
 
-    /** The last time at which {@link #generateReport} was run. */
+    /** The last time at which {@link #generateReport(long,boolean)} was run. */
     protected long _lastReportStamp = _serverStartTime;
 
     /** Used to generate "state of server" reports. */

src/java/com/threerings/presents/server/ShutdownManager.java

@@ -47,7 +47,7 @@ public class ShutdownManager
         void shutdown ();
     }
 
-    /** Constraints for use with {@link #addConstraint}. */
+    /** Constraints for use with {@link ShutdownManager#addConstraint}. */
     public static enum Constraint { RUNS_BEFORE, RUNS_AFTER };
 
     @Inject ShutdownManager (@EventQueue RunQueue dobjq)

src/java/com/threerings/presents/server/net/ConnectionManager.java

@@ -284,21 +284,20 @@ public class ConnectionManager extends LoopingThread
     {
         int successes = 0;
         IOException failure = null;
-        for (int ii = 0; ii < _ports.length; ii++) {
+        for (int port : _ports) {
             try {
                 // create a listening socket and add it to the select set
                 _ssocket = ServerSocketChannel.open();
                 _ssocket.configureBlocking(false);
 
-                InetSocketAddress isa = new InetSocketAddress(_ports[ii]);
+                InetSocketAddress isa = new InetSocketAddress(port);
                 _ssocket.socket().bind(isa);
                 registerChannel(_ssocket);
                 successes++;
                 log.info("Server listening on " + isa + ".");
 
             } catch (IOException ioe) {
-                log.warning("Failure listening to socket on port '" +
-                        _ports[ii] + "'.", ioe);
+                log.warning("Failure listening to socket on port '" + port + "'.", ioe);
                 failure = ioe;
             }
         }
@@ -940,7 +939,7 @@ public class ConnectionManager extends LoopingThread
         notifyObservers(CONNECTION_CLOSED, conn, null, null);
     }
 
-    /** Used to handle partial writes in {@link #writeMessage}. */
+    /** Used to handle partial writes in {@link ConnectionManager#writeMessage}. */
     protected static interface PartialWriteHandler
     {
         void handlePartialWrite (Connection conn, ByteBuffer buffer);