From 79efc4dd0d732908e2c2b3bf7f113c9a3ee862dc Mon Sep 17 00:00:00 2001 From: Ray Greenwell Date: Thu, 17 Aug 2006 22:16:04 +0000 Subject: [PATCH] Some comments laying about. git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@4329 542714f4-19e9-0310-aa3c-eee0fc999fb1 --- src/as/Log.as | 8 ++++++++ src/as/com/threerings/util/FlashObjectMarshaller.as | 4 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/as/Log.as b/src/as/Log.as index badefa5a9..9bd53efbb 100644 --- a/src/as/Log.as +++ b/src/as/Log.as @@ -27,6 +27,14 @@ import mx.logging.targets.TraceTarget; * .... */ public class Log +// TODO: We should really change the name of this class. +// The reason for this is that when we load a client .swf we load it into +// a child ApplicationDomain so that it can share and interoperate with +// a few of our classes. Any classes we define will block classes of the +// same name being used by client swfs, as they'll instead instantiate +// our versions. Normally this isn't a problem because our classnames are +// things like com.threerings.io.Streamable, but this class is just "Log". +// So: we should fix this up. { /** * Retrieve a Log for the specififed class. diff --git a/src/as/com/threerings/util/FlashObjectMarshaller.as b/src/as/com/threerings/util/FlashObjectMarshaller.as index 984190251..00aed08b5 100644 --- a/src/as/com/threerings/util/FlashObjectMarshaller.as +++ b/src/as/com/threerings/util/FlashObjectMarshaller.as @@ -2,6 +2,8 @@ package com.threerings.util { import flash.net.ObjectEncoding; +import flash.system.ApplicationDomain; + import flash.utils.ByteArray; import flash.utils.Endian; @@ -32,7 +34,7 @@ public class FlashObjectMarshaller return null; } - // TODO: Our own encoding, that takes into account + // TODO: Our own decoding, that takes into account // the ApplicationDomain bytes.endian = Endian.BIG_ENDIAN; bytes.objectEncoding = ObjectEncoding.AMF3;