From 776db7fe26effe849841b14e99801a694fcf658e Mon Sep 17 00:00:00 2001 From: "Ray J. Greenwell" Date: Fri, 14 Sep 2012 11:16:50 -0700 Subject: [PATCH] Avoid "if false return false". But really, these methods should throw an Exception if the key is no good. Not just return false, which nobody is probably checking. --- .../presents/server/net/PresentsConnectionManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/com/threerings/presents/server/net/PresentsConnectionManager.java b/core/src/main/java/com/threerings/presents/server/net/PresentsConnectionManager.java index 8a8abcf35..3533e76a8 100644 --- a/core/src/main/java/com/threerings/presents/server/net/PresentsConnectionManager.java +++ b/core/src/main/java/com/threerings/presents/server/net/PresentsConnectionManager.java @@ -167,7 +167,7 @@ public class PresentsConnectionManager extends ConnectionManager */ public boolean setPrivateKey (String key) { - return key == null ? false : setPrivateKey(SecureUtil.stringToRSAPrivateKey(key)); + return (key != null) && setPrivateKey(SecureUtil.stringToRSAPrivateKey(key)); } /**