From 61bee1b160fcdb89fb22a0d15bac26ec4c58b13a Mon Sep 17 00:00:00 2001 From: "Ray J. Greenwell" Date: Fri, 5 Jan 2018 15:20:29 -0800 Subject: [PATCH] Revert "Update javadoc with the truth about peers' internalHostName." This reverts commit ec471822631568fbb47a7de7e20bed1918c052f3. Ummm? I misread the code? So embarassing. For some reason I thought it was using the public hostname for all connections. Perhaps I misread the 'hostName' local variable in a PeerNode method for the 'hostName' in the record. --- .../com/threerings/presents/peer/server/PeerManager.java | 9 +++------ .../com/threerings/presents/peer/server/PeerNode.java | 5 +---- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/core/src/main/java/com/threerings/presents/peer/server/PeerManager.java b/core/src/main/java/com/threerings/presents/peer/server/PeerManager.java index e032e802c..3f70362ed 100644 --- a/core/src/main/java/com/threerings/presents/peer/server/PeerManager.java +++ b/core/src/main/java/com/threerings/presents/peer/server/PeerManager.java @@ -765,12 +765,9 @@ public abstract class PeerManager } /** - * Returns the internal hostname to use when connecting to the specified peer - * or null if the peer is not currently connected to this server. - * Peers connect to one another via their internal hostname. - * Do not publish this data to clients out on the Internets. - * NOTE: Peers now use the public host name for connections. This method may be - * deprecated in the future. + * Returns the internal hostname to use when connecting to the specified peer or null if the + * peer is not currently connected to this server. Peers connect to one another via their + * internal hostname. Do not publish this data to clients out on the Internets. */ public String getPeerInternalHostName (String nodeName) { diff --git a/core/src/main/java/com/threerings/presents/peer/server/PeerNode.java b/core/src/main/java/com/threerings/presents/peer/server/PeerNode.java index 283863a29..0a062e1a8 100644 --- a/core/src/main/java/com/threerings/presents/peer/server/PeerNode.java +++ b/core/src/main/java/com/threerings/presents/peer/server/PeerNode.java @@ -113,10 +113,7 @@ public class PeerNode } /** - * Returns the "internal" hostname - * for internal clients to use when connecting to this peer which is - * no longer really used. NOTE: Peers now use the public host name for connections. - * This method may be deprecated in the future. + * Returns the hostname for internal clients to use when connecting to this peer. */ public String getInternalHostName () {