Occam's razor.

git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@3296 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/presents/dobj/AttributeChangedEvent.java

@@ -21,6 +21,8 @@
 
 package com.threerings.presents.dobj;
 
+import java.lang.reflect.Array;
+
 import java.util.HashMap;
 
 import com.samskivert.util.StringUtil;
@@ -124,10 +126,11 @@ public class AttributeChangedEvent extends NamedEvent
                     // expensive isAssignableFrom check on primitives
                     // which are far and away the most common case
                 } else if (vclass.isArray()) {
-                    Cloner cloner = (Cloner)_cloners.get(vclass);
+                    int length = Array.getLength(value);
-                    if (cloner != null) {
+                    Object clone = Array.newInstance(
-                        value = cloner.clone(value);
+                        vclass.getComponentType(), length);
-                    }
+                    System.arraycopy(value, 0, clone, 0, length);
+                    value = clone;
                 } else if (DSet.class.isAssignableFrom(vclass)) {
                     value = ((DSet)value).clone();
                 }
@@ -177,66 +180,6 @@ public class AttributeChangedEvent extends NamedEvent
         StringUtil.toString(buf, _value);
     }
 
-    /** Used to clone object attributes without a zillion calls to
-     * instanceof. */
-    protected static interface Cloner {
-        public Object clone (Object object);
-    }
-
     protected Object _value;
     protected transient Object _oldValue = UNSET_OLD_VALUE;
-
-    /** Contains {@link Cloner}s for types that need cloning. */
-    protected static HashMap _cloners = new HashMap();
-
-    /** Object prototypes we can use to get the appropriate class objects
-     * for use when setting up {@link #_cloners}. */
-    protected static final Object[] ARRAY_PROTOS = new Object[] {
-        new String[0], new byte[0], new char[0], new short[0], new int[0],
-        new long[0], new float[0], new double[0]
-    };
-
-    // set up our cloners
-    static {
-        _cloners.put(ARRAY_PROTOS[0], new Cloner() {
-            public Object clone (Object obj) {
-                return ((String[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[1], new Cloner() {
-            public Object clone (Object obj) {
-                return ((byte[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[2], new Cloner() {
-            public Object clone (Object obj) {
-                return ((char[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[3], new Cloner() {
-            public Object clone (Object obj) {
-                return ((short[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[4], new Cloner() {
-            public Object clone (Object obj) {
-                return ((int[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[5], new Cloner() {
-            public Object clone (Object obj) {
-                return ((long[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[6], new Cloner() {
-            public Object clone (Object obj) {
-                return ((float[])obj).clone();
-            }
-        });
-        _cloners.put(ARRAY_PROTOS[7], new Cloner() {
-            public Object clone (Object obj) {
-                return ((double[])obj).clone();
-            }
-        });
-    }
 }