Operate on a snapshot of the overflow queue values as a connection may fail

while we're processing its overflow messages, which causes its overflow queue
to be cleared which causes a ConcurrentModificationException.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@5613 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/presents/server/net/ConnectionManager.java

@@ -642,14 +642,14 @@ public class ConnectionManager extends LoopingThread
     {
         // first attempt to send any messages waiting on the overflow queues
         if (_oflowqs.size() > 0) {
-            Iterator<OverflowQueue> oqiter = _oflowqs.values().iterator();
+            // do this on a snapshot as a network failure writing oflow queue messages will result
-            while (oqiter.hasNext()) {
+            // in the queue being removed from _oflowqs via the connectionFailed() code path
-                OverflowQueue oq = oqiter.next();
+            for (OverflowQueue oq : _oflowqs.values().toArray(new OverflowQueue[_oflowqs.size()])) {
                 try {
                     // try writing the messages in this overflow queue
                     if (oq.writeOverflowMessages(iterStamp)) {
                         // if they were all written, we can remove it
-                        oqiter.remove();
+                        _oflowqs.remove(oq.conn);
                     }
 
                 } catch (IOException ioe) {