405 modified source files and 17,367 lines of diffs later we now enforce

more discipline when handling names in our code base. Any user entered
name should find its way into a Name object as soon as it comes out of a
text field or whatnot, and stay that way until it makes its way into a
text field or into a database record (for which String objects are vastly
simpler because of JORA magic).

Dear God, let me never again make a change this large for the rest of my
mortal life.

Unfortunately, this means we have to keep an eye out for funny business
pretty much everywhere. However, since we will absolutely want to test
market stalls and so forth on Azure, we'll have an opportunity to iron out
any funny business that might fall under the radar during our internal
testing.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@2980 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/whirled/spot/server/SpotProvider.java

@@ -1,9 +1,10 @@
 //
-// $Id: SpotProvider.java,v 1.23 2004/02/25 14:50:28 mdb Exp $
+// $Id: SpotProvider.java,v 1.24 2004/03/06 11:29:19 mdb Exp $
 
 package com.threerings.whirled.spot.server;
 
 import com.samskivert.util.StringUtil;
+import com.threerings.util.Name;
 
 import com.threerings.presents.data.ClientObject;
 import com.threerings.presents.dobj.RootDObjectManager;
@@ -253,7 +254,7 @@ public class SpotProvider
      * @param message the text of the chat message.
      */
     public void sendClusterChatMessage (
-        int sceneId, int speakerOid, String speaker,
+        int sceneId, int speakerOid, Name speaker,
         String bundle, String message, byte mode)
     {
         // look up the scene manager for the specified scene

src/java/com/threerings/whirled/spot/server/SpotSceneManager.java

@@ -1,5 +1,5 @@
 //
-// $Id: SpotSceneManager.java,v 1.50 2004/02/25 14:50:28 mdb Exp $
+// $Id: SpotSceneManager.java,v 1.51 2004/03/06 11:29:19 mdb Exp $
 
 package com.threerings.whirled.spot.server;
 
@@ -7,6 +7,7 @@ import java.util.Iterator;
 
 import com.samskivert.util.HashIntMap;
 import com.samskivert.util.IntIntMap;
+import com.threerings.util.Name;
 
 import com.threerings.presents.dobj.DObject;
 import com.threerings.presents.dobj.Subscriber;
@@ -368,7 +369,7 @@ public class SpotSceneManager extends SceneManager
      * request.
      */
     protected void handleClusterSpeakRequest (
-        int sourceOid, String source, String bundle, String message, byte mode)
+        int sourceOid, Name source, String bundle, String message, byte mode)
     {
         ClusterRecord clrec = getCluster(sourceOid);
         if (clrec == null) {