405 modified source files and 17,367 lines of diffs later we now enforce
more discipline when handling names in our code base. Any user entered name should find its way into a Name object as soon as it comes out of a text field or whatnot, and stay that way until it makes its way into a text field or into a database record (for which String objects are vastly simpler because of JORA magic). Dear God, let me never again make a change this large for the rest of my mortal life. Unfortunately, this means we have to keep an eye out for funny business pretty much everywhere. However, since we will absolutely want to test market stalls and so forth on Azure, we'll have an opportunity to iron out any funny business that might fall under the radar during our internal testing. git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@2980 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
@@ -1,8 +1,10 @@
|
||||
//
|
||||
// $Id: BodyObject.java,v 1.8 2003/09/18 17:53:48 mdb Exp $
|
||||
// $Id: BodyObject.java,v 1.9 2004/03/06 11:29:19 mdb Exp $
|
||||
|
||||
package com.threerings.crowd.data;
|
||||
|
||||
import com.threerings.util.Name;
|
||||
|
||||
import com.threerings.presents.data.ClientObject;
|
||||
import com.threerings.crowd.chat.data.SpeakObject;
|
||||
|
||||
@@ -28,7 +30,7 @@ public class BodyObject extends ClientObject
|
||||
/**
|
||||
* The username associated with this body object.
|
||||
*/
|
||||
public String username;
|
||||
public Name username;
|
||||
|
||||
/**
|
||||
* The oid of the place currently occupied by this body or -1 if they
|
||||
@@ -62,7 +64,7 @@ public class BodyObject extends ClientObject
|
||||
// documentation inherited
|
||||
public String who ()
|
||||
{
|
||||
StringBuffer buf = new StringBuffer(username);
|
||||
StringBuffer buf = new StringBuffer(username.toString());
|
||||
buf.append(" (").append(getOid());
|
||||
if (status != OccupantInfo.ACTIVE) {
|
||||
buf.append(" ").append(OccupantInfo.X_STATUS[status]);
|
||||
@@ -78,7 +80,7 @@ public class BodyObject extends ClientObject
|
||||
* clients) will apply the value change when they received the
|
||||
* attribute changed notification.
|
||||
*/
|
||||
public void setUsername (String username)
|
||||
public void setUsername (Name username)
|
||||
{
|
||||
requestAttributeChange(USERNAME, username);
|
||||
this.username = username;
|
||||
|
||||
Reference in New Issue
Block a user