From 27d7a599943adee3e41a4d0f94cf8c3591821349 Mon Sep 17 00:00:00 2001 From: Michael Bayne Date: Fri, 4 Oct 2002 01:33:10 +0000 Subject: [PATCH] Transactions should be started outside the try/finally block that ensures their committal. This prevents double-fuckage if starting the transaction fails (because the finally block would still be executed which would try to end the non-existent transaction, throwing another exception which hides the first). git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@1774 542714f4-19e9-0310-aa3c-eee0fc999fb1 --- src/java/com/threerings/whirled/zone/server/ZoneProvider.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/java/com/threerings/whirled/zone/server/ZoneProvider.java b/src/java/com/threerings/whirled/zone/server/ZoneProvider.java index 5accf8f90..229d08274 100644 --- a/src/java/com/threerings/whirled/zone/server/ZoneProvider.java +++ b/src/java/com/threerings/whirled/zone/server/ZoneProvider.java @@ -1,5 +1,5 @@ // -// $Id: ZoneProvider.java,v 1.11 2002/09/20 00:54:06 mdb Exp $ +// $Id: ZoneProvider.java,v 1.12 2002/10/04 01:33:10 mdb Exp $ package com.threerings.whirled.zone.server; @@ -152,8 +152,8 @@ public class ZoneProvider // now that we've finally moved, we can update the user object // with the new scene and zone ids + source.startTransaction(); try { - source.startTransaction(); ((ScenedBodyObject)source).setSceneId(scmgr.getScene().getId()); ((ZonedBodyObject)source).setZoneId(summary.zoneId); } finally {