From 2726f6a29d4542b6f089e0635a5a86719db93baf Mon Sep 17 00:00:00 2001 From: Ray Greenwell Date: Mon, 14 Jul 2003 23:46:03 +0000 Subject: [PATCH] Slight optimization to chat history pruning. git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@2710 542714f4-19e9-0310-aa3c-eee0fc999fb1 --- .../crowd/chat/server/SpeakProvider.java | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/java/com/threerings/crowd/chat/server/SpeakProvider.java b/src/java/com/threerings/crowd/chat/server/SpeakProvider.java index 0886e938e..d202399ec 100644 --- a/src/java/com/threerings/crowd/chat/server/SpeakProvider.java +++ b/src/java/com/threerings/crowd/chat/server/SpeakProvider.java @@ -1,5 +1,5 @@ // -// $Id: SpeakProvider.java,v 1.13 2003/06/24 05:19:57 mdb Exp $ +// $Id: SpeakProvider.java,v 1.14 2003/07/14 23:46:03 ray Exp $ package com.threerings.crowd.chat.server; @@ -285,19 +285,14 @@ public class SpeakProvider */ protected static void pruneHistory (long now, HistoryList history) { - int prunepos = -1; - for (int ii = 0, ll = history.size(); ii < ll; ii++) { - ChatMessage msg = (ChatMessage)history.get(ii); - if (now - msg.timestamp > HISTORY_EXPIRATION) { - // Log.info("Expiring from history " + msg + "."); - prunepos = ii; - } else { + int prunepos = 0; + for (int ll = history.size(); prunepos < ll; prunepos++) { + ChatMessage msg = (ChatMessage)history.get(prunepos); + if (now - msg.timestamp < HISTORY_EXPIRATION) { break; // stop when we get to the first valid message } } - if (prunepos >= 0) { - history.remove(0, prunepos+1); - } + history.remove(0, prunepos); } /** Used to note the recipients of a chat message. */