Use the valueOf factory methods pretty much everywhere.

These are the preferred way to get instances of Boolean, Byte,
Short, Character, Integer, Long, Float, and Double object.
It's always made sense for Boolean objects, and with 1.5 these factory
methods were blessed as the proper way to get instances unless one
absolutely needed a distinct object.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@4145 542714f4-19e9-0310-aa3c-eee0fc999fb1

src/java/com/threerings/presents/server/InvocationManager.java

@@ -125,7 +125,7 @@ public class InvocationManager
             bootlist.add(marsh);
         }
 
-        _recentRegServices.put(new Integer(invCode),
+        _recentRegServices.put(Integer.valueOf(invCode),
                                marsh.getClass().getName());
 
 //        Log.info("Registered service [marsh=" + marsh + "].");
@@ -229,7 +229,7 @@ public class InvocationManager
                      "registration was already cleared [code=" + invCode +
                      ", methId=" + methodId +
                      ", args=" + StringUtil.toString(args) + ", marsh=" +
-                     _recentRegServices.get(new Integer(invCode)) + "].");
+                     _recentRegServices.get(Integer.valueOf(invCode)) + "].");
             return;
         }
 

src/java/com/threerings/presents/server/PresentsClient.java

@@ -208,7 +208,7 @@ public class PresentsClient
 
                 // let the client know that the rug has been yanked out
                 // from under their ass
-                Object[] args = new Object[] { new Integer(clobj.getOid()) };
+                Object[] args = new Object[] { Integer.valueOf(clobj.getOid()) };
                 _clobj.postMessage(ClientObject.CLOBJ_CHANGED, args);
 
                 // call down to any derived classes

src/java/com/threerings/presents/server/TimeBaseDispatcher.java

@@ -2,7 +2,7 @@
 // $Id$
 //
 // Narya library - tools for developing networked games
-// Copyright (C) 2002-2005 Three Rings Design, Inc., All Rights Reserved
+// Copyright (C) 2002-2006 Three Rings Design, Inc., All Rights Reserved
 // http://www.threerings.net/code/narya/
 //
 // This library is free software; you can redistribute it and/or modify it
@@ -63,6 +63,7 @@ public class TimeBaseDispatcher extends InvocationDispatcher
 
         default:
             super.dispatchRequest(source, methodId, args);
+            return;
         }
     }
 }