AfflictionNetworks/narya
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use the fine grained timer (measure in microseconds rather than

Browse Source 
milliseconds) and same every 100th event instead of profiling every event.


git-svn-id: svn+ssh://src.earth.threerings.net/narya/trunk@2951 542714f4-19e9-0310-aa3c-eee0fc999fb1
This commit is contained in:
Michael Bayne
2004-02-09 02:08:28 +00:00
parent 596f55e315
commit 1d97122a81
1 changed files with 21 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/java/com/threerings/presents/server/PresentsDObjectMgr.java
+21 -32
View File
@@ -1,5 +1,5 @@
// //
// $Id: PresentsDObjectMgr.java,v 1.37 2003/08/16 04:14:56 mdb Exp $ // $Id: PresentsDObjectMgr.java,v 1.38 2004/02/09 02:08:28 mdb Exp $
package com.threerings.presents.server; package com.threerings.presents.server;
@@ -8,6 +8,8 @@ import java.util.HashMap;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
import sun.misc.Perf;
import com.samskivert.util.HashIntMap; import com.samskivert.util.HashIntMap;
import com.samskivert.util.Histogram; import com.samskivert.util.Histogram;
import com.samskivert.util.Queue; import com.samskivert.util.Queue;
@@ -173,8 +175,8 @@ public class PresentsDObjectMgr
// pop the next unit off the queue // pop the next unit off the queue
Object unit = _evqueue.get(); Object unit = _evqueue.get();
long start = 0L; long start = 0L;
if (UNIT_PROFILING) { if (_eventCount % UNIT_PROFILING_INTERVAL == 0) {
start = System.currentTimeMillis(); start = _timer.highResCounter();
} }
// if this is a runnable, it's just an executable unit that // if this is a runnable, it's just an executable unit that
@@ -194,11 +196,14 @@ public class PresentsDObjectMgr
processEvent((DEvent)unit); processEvent((DEvent)unit);
} }
if (UNIT_PROFILING) { if (start != 0L) {
long elapsed = System.currentTimeMillis() - start; long elapsed = _timer.highResCounter() - start;
// convert the elapsed time to microseconds
elapsed = elapsed * 1000000 / _timer.highResFrequency();
// report excessively long units // report excessively long units
if (elapsed > 500) { if (elapsed > 500000) {
Log.warning("Unit '" + StringUtil.safeToString(unit) + Log.warning("Unit '" + StringUtil.safeToString(unit) +
" [" + StringUtil.shortClassName(unit) + " [" + StringUtil.shortClassName(unit) +
"]' ran for " + elapsed + "ms."); "]' ran for " + elapsed + "ms.");
@@ -338,15 +343,10 @@ public class PresentsDObjectMgr
} }
/** /**
* Dumps collected profiling information to the system log. Does * Dumps collected profiling information to the system log.
* nothing if unit profiling is not enabled.
*/ */
public void dumpUnitProfiles () public void dumpUnitProfiles ()
{ {
if (!UNIT_PROFILING) {
return;
}
Iterator iter = _profiles.keySet().iterator(); Iterator iter = _profiles.keySet().iterator();
while (iter.hasNext()) { while (iter.hasNext()) {
String cname = (String)iter.next(); String cname = (String)iter.next();
@@ -858,34 +858,20 @@ public class PresentsDObjectMgr
{ {
public void record (long start, long elapsed) public void record (long start, long elapsed)
{ {
if (start - _lastRecorded > RECENT_INTERVAL) {
_recentElapsed = 0L;
_recentCount = 0;
}
_recentElapsed += elapsed;
_recentCount++;
_totalElapsed += elapsed; _totalElapsed += elapsed;
_lastRecorded = start;
_histo.addValue((int)elapsed); _histo.addValue((int)elapsed);
} }
public String toString () public String toString ()
{ {
int count = _histo.size(); int count = _histo.size();
return "r:" + _recentElapsed + " t:" + _totalElapsed + return "(" + _totalElapsed + "us/" + count + " = " +
" c:" + count + " ra:" + (_recentElapsed/_recentCount) + (_totalElapsed/count) + "us avg) " +
" ta:" + (_totalElapsed/count) + StringUtil.toString(_histo.getBuckets());
" h:" + StringUtil.toString(_histo.getBuckets());
} }
protected long _lastRecorded;
protected int _recentCount;
protected long _recentElapsed;
protected long _totalElapsed; protected long _totalElapsed;
protected Histogram _histo = new Histogram(0, 50, 10); protected Histogram _histo = new Histogram(0, 20000, 10);
protected static final long RECENT_INTERVAL = 5 * 60 * 1000L;
} }
/** A flag indicating that the event dispatcher is still running. */ /** A flag indicating that the event dispatcher is still running. */
@@ -921,11 +907,14 @@ public class PresentsDObjectMgr
* should not be called from the event dispatch thread. */ * should not be called from the event dispatch thread. */
protected Thread _dobjThread; protected Thread _dobjThread;
/** Used during unit profiling for timing values. */
protected Perf _timer = Perf.getPerf();
/** Used to profile our events and runnable units. */ /** Used to profile our events and runnable units. */
protected HashMap _profiles = new HashMap(); protected HashMap _profiles = new HashMap();
/** Indicates whether or not profiling is enabled. */ /** The frequency with which we take a profiling sample. */
protected static final boolean UNIT_PROFILING = true; protected static final int UNIT_PROFILING_INTERVAL = 100;
/** Check whether we should generate a report every 100 events. */ /** Check whether we should generate a report every 100 events. */
protected static final long REPORT_CHECK_PERIOD = 100; protected static final long REPORT_CHECK_PERIOD = 100;